Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

FIX: Ensure valid CSS classes for GridField header (fixes #2361)

  • Loading branch information...
commit 90952e7bd4bf7a278959ff320b3a71d30596f5d8 1 parent caecc05
@kinglozzer kinglozzer authored
Showing with 4 additions and 3 deletions.
  1. +4 −3 forms/gridfield/GridFieldSortableHeader.php
View
7 forms/gridfield/GridFieldSortableHeader.php
@@ -92,6 +92,7 @@ public function getHTMLFragments($gridField) {
foreach($columns as $columnField) {
$currentColumn++;
$metadata = $gridField->getColumnMetadata($columnField);
+ $fieldName = str_replace('.', '-', $columnField);
$title = $metadata['title'];
if(isset($this->fieldSorting[$columnField]) && $this->fieldSorting[$columnField]) {
@@ -132,7 +133,7 @@ public function getHTMLFragments($gridField) {
}
$field = Object::create(
- 'GridField_FormAction', $gridField, 'SetOrder'.$columnField, $title,
+ 'GridField_FormAction', $gridField, 'SetOrder'.$fieldName, $title,
"sort$dir", array('SortColumn' => $columnField)
)->addExtraClass('ss-gridfield-sort');
@@ -148,10 +149,10 @@ public function getHTMLFragments($gridField) {
if($currentColumn == count($columns)
&& $gridField->getConfig()->getComponentByType('GridFieldFilterHeader')){
- $field = new LiteralField($columnField,
+ $field = new LiteralField($fieldName,
'<button name="showFilter" class="ss-gridfield-button-filter trigger"></button>');
} else {
- $field = new LiteralField($columnField, '<span class="non-sortable">' . $title . '</span>');
+ $field = new LiteralField($fieldName, '<span class="non-sortable">' . $title . '</span>');
}
}
$forTemplate->Fields->push($field);
Please sign in to comment.
Something went wrong with that request. Please try again.