Browse files

RECOMMIT This is a recommit of a previously merged, but reverted, com…

…mit. The initial commit had problems when running "tests/all flush=all" when dev/build would re-analyse a bunch of stuff; fixes to address this went into #487, but for some reason the actual base changes didn't, so I'm re-submitting them in a separate pull.

BUGFIX Versioned's constructor doesn't provide suitable defaults. Previously a bug/feature in singleton, where it would pass null,true as params to strong_create, which would then get passed through as params to Versioned's constructor, meant that the code still executed fine (as was set to something that wasn't an array, so the null and true were instead taken as args). The fact that the usage of singleton(Versioned) never really used the classes code, purely for value lookup, meant that this never propagated errors. I've now switched singleton() to use the injector for retrieving values, which means these dud values are no longer passed through

CHANGE Given that Config::inst is an implementation of the singleton pattern itself, I've removed the extra call to singleton(). A side effect of this is that it gets around a possibly nasty circular reference with the dependency injector (which relies on the config object); in future, this dependency structure should really be structured from the DI directly.

MINOR Change singleton and strong_create to use dependency injector
  • Loading branch information...
1 parent 9898cd9 commit ae7fc6f4d259bd79fb079ff9c9769fb08cea283f Marcus Nyeholt committed Jun 3, 2012
Showing with 4 additions and 7 deletions.
  1. +1 −1 core/Config.php
  2. +1 −3 core/Core.php
  3. +1 −2 core/Object.php
  4. +1 −1 model/Versioned.php
@@ -118,7 +118,7 @@ static protected function type_mismatch() {
* @return Config
static public function inst() {
- if (!self::$instance) self::$instance = singleton('Config');
+ if (!self::$instance) self::$instance = new Config();
return self::$instance;
@@ -356,8 +356,6 @@ function getClassFile($className) {
* way to access instance methods which don't rely on instance
* data (e.g. the custom SilverStripe static handling).
- * @uses Object::strong_create()
- *
* @param string $className
* @return Object
@@ -367,7 +365,7 @@ function singleton($className) {
if(!is_string($className)) user_error("singleton() passed bad class_name: " . var_export($className,true), E_USER_ERROR);
if(!isset($_SINGLETONS[$className])) {
if(!class_exists($className)) user_error("Bad class to singleton() - $className", E_USER_ERROR);
- $_SINGLETONS[$className] = Object::strong_create($className,null, true);
+ $_SINGLETONS[$className] = Injector::inst()->get($className);
if(!$_SINGLETONS[$className]) user_error("singleton() Unknown class '$className'", E_USER_ERROR);
return $_SINGLETONS[$className];
@@ -234,8 +234,7 @@ public static function strong_create() {
$class = self::$strong_classes[$class];
- $reflector = new ReflectionClass($class);
- return $reflector->newInstanceArgs($args);
+ return Injector::inst()->createWithArgs($class, $args);
@@ -92,7 +92,7 @@ static function reset() {
* The first stage is consiedered the 'default' stage, the last stage is
* considered the 'live' stage.
- function __construct($stages) {
+ function __construct($stages=array('Stage','Live')) {
if(!is_array($stages)) {

0 comments on commit ae7fc6f

Please sign in to comment.