HTTPS clone URL
Subversion checkout URL
Please sign in to comment.
RECOMMIT This is a recommit of a previously merged, but reverted, com…
…mit. The initial commit had problems when running "tests/all flush=all" when dev/build would re-analyse a bunch of stuff; fixes to address this went into #487, but for some reason the actual base changes didn't, so I'm re-submitting them in a separate pull. BUGFIX Versioned's constructor doesn't provide suitable defaults. Previously a bug/feature in singleton, where it would pass null,true as params to strong_create, which would then get passed through as params to Versioned's constructor, meant that the code still executed fine (as was set to something that wasn't an array, so the null and true were instead taken as args). The fact that the usage of singleton(Versioned) never really used the classes code, purely for value lookup, meant that this never propagated errors. I've now switched singleton() to use the injector for retrieving values, which means these dud values are no longer passed through CHANGE Given that Config::inst is an implementation of the singleton pattern itself, I've removed the extra call to singleton(). A side effect of this is that it gets around a possibly nasty circular reference with the dependency injector (which relies on the config object); in future, this dependency structure should really be structured from the DI directly. MINOR Change singleton and strong_create to use dependency injector
- Loading branch information...
commit ae7fc6f4d259bd79fb079ff9c9769fb08cea283f 1 parent 9898cd9
Marcus Nyeholt authored
Showing with 4 additions and 7 deletions.