Skip to content
Browse files

NEW Amend Travis build to run a simple PHP_CodeSniffer test.

At this stage, the test just checks line-length and line-endings, but previous commits have ensured that framework actually passes those tests.  We can add more tests as we actually correct the code to pass those tests, and grow the test suite, as we had for unit tests.
  • Loading branch information...
1 parent 1f7fc1f commit b7e7c165ffd19943f01d1afeb93cc3e15474ef4b @sminnee sminnee committed
Showing with 41 additions and 0 deletions.
  1. +3 −0 .travis.yml
  2. +38 −0 tests/phpcs/ruleset.xml
View
3 .travis.yml
@@ -15,11 +15,14 @@ matrix:
env: TESTDB=SQLITE
before_script:
+ - pear install pear/PHP_CodeSniffer
+ - phpenv rehash
- ./tests/travis/before_script ~/builds/ss
- cd ~/builds/ss
script:
- phpunit -c phpunit.xml.dist
+ - phpcs --encoding=utf-8 --tab-width=4 --standard=framework/tests/phpcs -np framework
notifications:
irc:
View
38 tests/phpcs/ruleset.xml
@@ -0,0 +1,38 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<ruleset name="SilverStripe">
+ <description>CodeSniffer ruleset for SilverStripe coding conventions.</description>
+
+ <!-- exclude SCSS-generated CSS files -->
+ <exclude-pattern>*/css/*</exclude-pattern>
+ <exclude-pattern>css/*</exclude-pattern>
+
+ <!-- exclude thirdparty content -->
+ <exclude-pattern>thirdparty/*</exclude-pattern>
+ <exclude-pattern>*/jquery-changetracker/*</exclude-pattern>
+ <exclude-pattern>parsers/HTML/BBCodeParser/*</exclude-pattern>
+
+ <!-- PHP-PEG generated file not intended for human consumption -->
+ <exclude-pattern>*/SSTemplateParser.php$</exclude-pattern>
+
+ <rule ref="Generic.Files.LineEndings.InvalidEOLChar">
+ <severity>8</severity>
+ </rule>
+ <rule ref="Generic.Files.LineEndings">
+ <properties>
+ <property name="eolChar" value="\n" />
+ </properties>
+ </rule>
+ <rule ref="Generic.Files.LineLength.TooLong">
+ <severity>7</severity>
+ </rule>
+ <rule ref="Generic.Files.LineLength.MaxExceeded">
+ <severity>8</severity>
+ </rule>
+ <rule ref="Generic.Files.LineLength">
+ <properties>
+ <property name="lineLimit" value="120"/>
+ <property name="absoluteLineLimit" value="120"/>
+ </properties>
+ </rule>
+</ruleset>
+

0 comments on commit b7e7c16

Please sign in to comment.
Something went wrong with that request. Please try again.