Permalink
Browse files

BUG Fixing tabindex added to CreditCardField when tabindex is NULL

The tabindex increment *should* only be done if there is a tabindex
that has been set on a CreditCardField already, otherwise it breaks
the tab ordering.
  • Loading branch information...
1 parent a7f38f7 commit c453ea30948b1b7def1e03919f19caa1ffabda8e @halkyon halkyon committed Sep 19, 2013
Showing with 3 additions and 0 deletions.
  1. +3 −0 forms/CreditCardField.php
@@ -35,6 +35,9 @@ public function Field($properties = array()) {
* @return string
*/
protected function getTabIndexHTML($increment = 0) {
+ // we can't add a tabindex if there hasn't been one set yet.
+ if($this->getAttribute('tabindex') === null) return false;
+
$tabIndex = (int)$this->getAttribute('tabindex') + (int)$increment;
return (is_numeric($tabIndex)) ? ' tabindex = "' . $tabIndex . '"' : '';
}

0 comments on commit c453ea3

Please sign in to comment.