Skip to content
This repository
Browse code

Don't flush manifest in test bootstrap for performance reasons

Leave the decision to the phpunit.xml config (via <get> setting),
or to the individual run via "phpunit <folder> '' flush=1".
Flushing takes multiple seconds even on my fast SSD,
which greatly reduces the likelyhood of developers adopting TDD.
  • Loading branch information...
commit c8c84b0935365745da87b4010743565f4afa5a9b 1 parent 9ce0c9a
Ingo Schommer authored July 05, 2012

Showing 1 changed file with 1 addition and 4 deletions. Show diff stats Hide diff stats

  1. 5  tests/bootstrap.php
5  tests/bootstrap.php
@@ -42,9 +42,6 @@
42 42
 	$_REQUEST = array_merge($_REQUEST, $_GET);
43 43
 }
44 44
 
45  
-// Always flush the manifest for phpunit test runs
46  
-$_GET['flush'] = 1;
47  
-
48 45
 // Connect to database
49 46
 require_once $frameworkPath . '/core/Core.php';
50 47
 require_once $frameworkPath . '/tests/FakeController.php';
@@ -65,4 +62,4 @@
65 62
 TestRunner::use_test_manifest();
66 63
 
67 64
 // Remove the error handler so that PHPUnit can add its own
68  
-restore_error_handler();
  65
+restore_error_handler();

0 notes on commit c8c84b0

Please sign in to comment.
Something went wrong with that request. Please try again.