Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Don't flush manifest in test bootstrap for performance reasons

Leave the decision to the phpunit.xml config (via <get> setting),
or to the individual run via "phpunit <folder> '' flush=1".
Flushing takes multiple seconds even on my fast SSD,
which greatly reduces the likelyhood of developers adopting TDD.
  • Loading branch information...
commit c8c84b0935365745da87b4010743565f4afa5a9b 1 parent 9ce0c9a
@chillu chillu authored
Showing with 1 addition and 4 deletions.
  1. +1 −4 tests/bootstrap.php
View
5 tests/bootstrap.php
@@ -42,9 +42,6 @@
$_REQUEST = array_merge($_REQUEST, $_GET);
}
-// Always flush the manifest for phpunit test runs
-$_GET['flush'] = 1;
-
// Connect to database
require_once $frameworkPath . '/core/Core.php';
require_once $frameworkPath . '/tests/FakeController.php';
@@ -65,4 +62,4 @@
TestRunner::use_test_manifest();
// Remove the error handler so that PHPUnit can add its own
-restore_error_handler();
+restore_error_handler();

0 comments on commit c8c84b0

Please sign in to comment.
Something went wrong with that request. Please try again.