BUG Added warning for auto-generated table_name for non-test classes

silverstripe · Nov 27, 2017 · cc72b5c · cc72b5c
1 parent 7c39973
commit cc72b5c
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 4 deletions.
diff --git a/src/ORM/DataObjectSchema.php b/src/ORM/DataObjectSchema.php
@@ -6,6 +6,7 @@
 use SilverStripe\Core\Injector\Injectable;
 use SilverStripe\Core\Config\Configurable;
 use SilverStripe\Core\Injector\Injector;
+use SilverStripe\Dev\TestOnly;
 use SilverStripe\ORM\FieldType\DBComposite;
 use SilverStripe\Core\ClassInfo;
 use SilverStripe\Core\Config\Config;
@@ -126,6 +127,7 @@ public function tableName($class)
         }
         return null;
     }
+
     /**
      * Returns the root class (the first to extend from DataObject) for the
      * passed class.
@@ -301,10 +303,25 @@ protected function buildTableName($class)
         $table = Config::inst()->get($class, 'table_name', Config::UNINHERITED);
 
         // Generate default table name
-        if (!$table) {
-            $separator = DataObjectSchema::config()->uninherited('table_namespace_separator');
-            $table = str_replace('\\', $separator, trim($class, '\\'));
+        if ($table) {
+            return $table;
+        }
+
+        if (strpos($class, '\\') === false) {
+            return $class;
+        }
+
+        if (!ClassInfo::classImplements($class, TestOnly::class)) {
+            trigger_error(
+                "It is recommended to define a table_name for your '$class'." .
+                ' Not defining a table_name may cause subsequent table names to be too long and may not be supported' .
+                ' by your current database engine, the generated naming scheme will also change when upgrading to' .
+                ' SilverStripe 5.0 and potentially break.',
+                E_USER_WARNING
+            );
         }
+        $separator = DataObjectSchema::config()->uninherited('table_namespace_separator');
+        $table = str_replace('\\', $separator, trim($class, '\\'));
 
         return $table;
     }

diff --git a/tests/php/Core/ClassInfoTest/ChildClass.php b/tests/php/Core/ClassInfoTest/ChildClass.php
@@ -2,7 +2,9 @@
 
 namespace SilverStripe\Core\Tests\ClassInfoTest;
 
-class ChildClass extends BaseClass
+use SilverStripe\Dev\TestOnly;
+
+class ChildClass extends BaseClass implements TestOnly
 {
 
 }