Permalink
Browse files

MINOR Don't throw deprecation notice on DataObjectSet and FieldSet if…

… there's still over 500 (!) references to them in core, as it basically means that everybody has to suppress PHP NOTICE errors for months, impacting core code quality
  • Loading branch information...
1 parent 7b38fcf commit df56eb540a6dd1fbf833582057abe5416634811d @chillu chillu committed Oct 4, 2011
Showing with 7 additions and 7 deletions.
  1. +3 −3 forms/FieldSet.php
  2. +4 −4 model/DataObjectSet.php
View
@@ -8,9 +8,9 @@
class FieldSet extends FieldList {
public function __construct($items = array()) {
- user_error(
- 'FieldSet is deprecated, please use FieldList instead.', E_USER_NOTICE
- );
+ // user_error(
+ // 'FieldSet is deprecated, please use FieldList instead.', E_USER_NOTICE
+ // );
parent::__construct(!is_array($items) || func_num_args() > 1 ? func_get_args(): $items);
}
@@ -7,10 +7,10 @@
class DataObjectSet extends ArrayList {
public function __construct($items = array()) {
- user_error(
- 'DataObjectSet is deprecated, please use DataList or ArrayList instead.',
- E_USER_NOTICE
- );
+ // user_error(
+ // 'DataObjectSet is deprecated, please use DataList or ArrayList instead.',
+ // E_USER_NOTICE
+ // );
if ($items) {
if (!is_array($items) || func_num_args() > 1) {

0 comments on commit df56eb5

Please sign in to comment.