diff --git a/forms/HtmlEditorField.php b/forms/HtmlEditorField.php index 45a56d9f1aa..3afcaef8197 100644 --- a/forms/HtmlEditorField.php +++ b/forms/HtmlEditorField.php @@ -515,7 +515,8 @@ public function viewfile($request) { } // Instanciate file wrapper and get fields based on its type - if($file && $file->appCategory() == 'image') { + // Check if appCategory is an image and exists on the local system, otherwise use oEmbed to refference a remote image + if($file && $file->appCategory() == 'image' && Director::is_site_url($url)) { $fileWrapper = new HtmlEditorField_Image($url, $file); } elseif(!Director::is_site_url($url)) { $fileWrapper = new HtmlEditorField_Embed($url, $file); diff --git a/oembed/Oembed.php b/oembed/Oembed.php index 7017a3d24af..9638da5603f 100644 --- a/oembed/Oembed.php +++ b/oembed/Oembed.php @@ -131,6 +131,13 @@ public static function get_oembed_from_url($url, $type = false, array $options = // Build the url manually - we gave all needed information. $oembedUrl = Controller::join_links($endpoint, '?format=json&url=' . rawurlencode($url)); } + + // If autodescovery failed the resource might be a direct link to a file + if(!$oembedUrl) { + if(File::get_app_category(File::get_file_extension($url))) { + return new Oembed_Result($url, $url, $type, $options); + } + } if($oembedUrl) { // Inject the options into the Oembed URL. @@ -233,7 +240,20 @@ protected function loadData() { $body = $body->getBody(); $data = json_decode($body, true); if(!$data) { + // if the response is no valid JSON we might have received a binary stream to an image $data = array(); + $image = @imagecreatefromstring($body); + if($image !== FALSE) { + preg_match("/^(http:\/\/)?([^\/]+)/i", $this->url, $matches); + $protocoll = $matches[1]; + $host = $matches[2]; + $data['type'] = "photo"; + $data['title'] = basename($this->url) . " ($host)"; + $data['url'] = $this->url; + $data['provider_url'] = $protocoll.$host; + $data['width'] = imagesx($image); + $data['height'] = imagesy($image); + } } // Convert all keys to lowercase