Permalink
Commits on Feb 2, 2011
  1. API CHANGE Don't reflect changes in File and Folder property setters …

    …on filesystem before write() is called, to ensure that validate() applies in all cases. This fixes a problem where File->setName() would circumvent restrictions in File::$allowed_extensions (fixes #5693)
    
    API CHANGE Removed File->resetFilename(), use File->updateFilesystem() to update the filesystem, and File->getRelativePath() to just update the "Filename" property without any filesystem changes (emulating the old $renamePhysicalFile method argument in resetFilename())
    API CHANGE Removed File->autosetFilename(), please set the "Filename" property via File->getRelativePath()
    MINOR Added unit tests to FileTest and FolderTest (some of them copied from FileTest, to test Folder behaviour separately)
    ENHANCEMENT Added File::$allowed_extensions (backport from 2.4 to enable File->validate() security fix)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@108062 467b73ca-7a2a-4603-9d3b-597d59a354a9
    chillu committed with sminnee Jul 16, 2010
  2. BUGFIX: Don't allow direct access to PHP files in sapphire module, ex…

    …cept for main.php and static-main.php (from r108023)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@108043 467b73ca-7a2a-4603-9d3b-597d59a354a9
    chillu committed with sminnee Jul 16, 2010
  3. MINOR Added querystring option to Makefile (from r103884)

    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@103897 467b73ca-7a2a-4603-9d3b-597d59a354a9
    chillu committed with sminnee May 3, 2010
  4. ENHANCEMENT Allowing TestRunner? to skip certain tests through the ?S…

    …kipTests?=... GET paramete (merged from branches/2.3-nzct) (from r80646)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@103684 467b73ca-7a2a-4603-9d3b-597d59a354a9
    chillu committed with sminnee Apr 28, 2010
  5. MINOR: Fixed FileTest execution if the assets/ directory doesn't exis…

    …t. (from r88353) (from r98086)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@103521 467b73ca-7a2a-4603-9d3b-597d59a354a9
    chillu committed with sminnee Apr 26, 2010
  6. MINOR Fixed missing closing <div> in ContentController->successfullyi…

    …nstalled() (from r101254)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@101258 467b73ca-7a2a-4603-9d3b-597d59a354a9
    halkyon committed with sminnee Mar 18, 2010
  7. BUGFIX Don't delete index.php after successful installation - in Cont…

    …entController->deleteinstallfiles(). URL routing might rely on it without mod_rewrite.
    
    BUGFIX Require ADMIN permissions for ContentController->deleteinstallfiles() - together with retaining index.php this removed a vulnerability where unauthenticated users can disrupt mod_rewrite-less URL routing. (from r101227)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@101229 467b73ca-7a2a-4603-9d3b-597d59a354a9
    chillu committed with sminnee Mar 17, 2010
  8. BUGFIX Fixing Member_ProfileForm to validate for existing members via…

    … Member_Validator to avoid CMS users to switch to another existing user account by using their email address (from r100704) (from r100717)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@100744 467b73ca-7a2a-4603-9d3b-597d59a354a9
    chillu committed with sminnee Mar 9, 2010
  9. MINOR Readded sapphire/thirdparty modules without svn:externals

    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@99765 467b73ca-7a2a-4603-9d3b-597d59a354a9
    chillu committed with sminnee Feb 24, 2010
  10. MINOR Fixed HTTPTest->testSetGetVar() (merged from r98409)

    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@98410 467b73ca-7a2a-4603-9d3b-597d59a354a9
    chillu committed with sminnee Feb 8, 2010
  11. MINOR Fixed HTTPTest->testSetGetVar() (merged from r98407)

    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@98408 467b73ca-7a2a-4603-9d3b-597d59a354a9
    chillu committed with sminnee Feb 8, 2010
  12. MINOR Added test case for Hierarchy::getDescendantIDList() which also…

    … tests Hierarchy::loadDescendantIDListInto() (merged from r98369)
    
    MINOR Testing of grand-children items in HierarchyTest::testLoadDescendantIDListIntoArray() and HierarchyTest::testNumChildren() (merged from r98376)
    BUGFIX #5044 Hierarchy::loadDescendantIDListInto() now uses Object::getExtensionInstance('Hierarchy') instead of going through call(), as PHP 5.3 has issues converting references to values
    BUGFIX Fixed Hierarchy->loadDescendantIdList() to call setOwner() on the extension instance. This was necessary due to underlying Object/Extension changes in 2.4. (merged from r98403)
    MINOR Fixed HierarchyTest assertions around including grand children counts (merged from r98403)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@98405 467b73ca-7a2a-4603-9d3b-597d59a354a9
    chillu committed with sminnee Feb 8, 2010
  13. MINOR Fixed HTTPTest when invoked through dev/tests/all or with GET p…

    …arameters (see r98373) (merged from r98383)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@98384 467b73ca-7a2a-4603-9d3b-597d59a354a9
    chillu committed with sminnee Feb 8, 2010
  14. API CHANGE HTTP::setGetVar() always returns absolute URLs. Use Direct…

    …or::makeRelative() to make them relative again. (merged from r98373)
    
    API CHANGE HTTP::setGetVar() combines any GET parameters in PHP array notation (e.g. "foo[bar]=val") instead of replacing the whole array (merged from r98373)
    BUGFIX HTTP::setGetVar() uses parse_url() and http_build_query() to add query parameters to an existing URL, instead of doing its own regex-based parsing. This means existing GET parameters are correctly url encoded. (merged from r98373)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@98375 467b73ca-7a2a-4603-9d3b-597d59a354a9
    chillu committed with sminnee Feb 8, 2010
  15. BUGFIX: Don't force SSL when running from CLI

    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@98273 467b73ca-7a2a-4603-9d3b-597d59a354a9
    ajoneil committed with sminnee Feb 5, 2010
  16. BUGFIX Disabled ?debug_profile=1 on live environment types (merged fr…

    …om r80057)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@98230 467b73ca-7a2a-4603-9d3b-597d59a354a9
    chillu committed with sminnee Feb 4, 2010
  17. BUGFIX Limiting ?debug_memory parameter to development environments t…

    …hrough using Debug::message() instead of a straight echo() (merged from r74067)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@98229 467b73ca-7a2a-4603-9d3b-597d59a354a9
    chillu committed with sminnee Feb 4, 2010
  18. ENHANCEMENT: Removed dev/reset, instead encouraging the use of dev/te…

    …sts/startsession for tests.
    
    ENHANCEMENT: Let people use dev/tests/startsession without a fixture, instead calling requireDefaultRecords
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@98081 467b73ca-7a2a-4603-9d3b-597d59a354a9
    sminnee committed Feb 3, 2010
  19. MINOR: fixed notice level error when ImageSource isnt set

    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@97004 467b73ca-7a2a-4603-9d3b-597d59a354a9
    Will Rossiter committed with sminnee Jan 15, 2010
  20. BUGFIX: fixed TaskRunner generating link with 2 slashes

    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@96998 467b73ca-7a2a-4603-9d3b-597d59a354a9
    Will Rossiter committed with sminnee Jan 15, 2010
  21. BUGFIX: convert ImageFormAction form prototype syntax to jQuery syntax

    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@94304 467b73ca-7a2a-4603-9d3b-597d59a354a9
    Normann Lou committed with sminnee Dec 3, 2009
  22. BUGFIX: fix for multiple EmailField validation on one form. Merged vi…

    …a r78565
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@93483 467b73ca-7a2a-4603-9d3b-597d59a354a9
    Will Rossiter committed with sminnee Nov 25, 2009
  23. MINOR Merged in Versioned::get_all_versions() fix from r76223

    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@92161 467b73ca-7a2a-4603-9d3b-597d59a354a9
    halkyon committed with sminnee Nov 19, 2009
  24. BUGFIX: Made use of new BasicAuth::protect_entire_site() consistent. …

    …(from r91658)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@91660 467b73ca-7a2a-4603-9d3b-597d59a354a9
    sminnee committed Nov 15, 2009
  25. BUGFIX: Don't enable site-wide protection by default (from r91609)

    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@91611 467b73ca-7a2a-4603-9d3b-597d59a354a9
    sminnee committed Nov 15, 2009
  26. API CHANGE: Replaced BasicAuth::enable() with BasicAuth::protect_enti…

    …re_site()
    
    API CHANGE: BasicAuth::requireLogin() no longer has an option to automatically log you in.  You can call logIn() on the object returned, instead. (from r91603)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@91610 467b73ca-7a2a-4603-9d3b-597d59a354a9
    sminnee committed Nov 15, 2009
  27. MINOR: CheckboxSetField::dataValue() returns a string not array.

    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@91105 467b73ca-7a2a-4603-9d3b-597d59a354a9
    Normann Lou committed with sminnee Nov 9, 2009
  28. API CHANGE: Added SapphireTest::logInWithPermission() (merged from r8…

    …9209)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@91034 467b73ca-7a2a-4603-9d3b-597d59a354a9
    chillu committed with sminnee Nov 9, 2009
  29. BUGFIX: Added rewriteHashlinks = 'php' option to SSViewer so that sta…

    …tic publisher can handle internal hashlinks properly.
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@89611 467b73ca-7a2a-4603-9d3b-597d59a354a9
    sminnee committed Oct 20, 2009
  30. reverted

    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@88282 467b73ca-7a2a-4603-9d3b-597d59a354a9
    ajoneil committed with sminnee Oct 7, 2009
  31. BUGFIX: Ensure ASSETS_PATH is respected

    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@88281 467b73ca-7a2a-4603-9d3b-597d59a354a9
    ajoneil committed with sminnee Oct 7, 2009
  32. API CHANGE: Added increase_time_limit_to(), which respects safe_mode.

    API CHANGE: Added no-arg option to increase_memory_limit_to() (from r80241)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@88176 467b73ca-7a2a-4603-9d3b-597d59a354a9
    sminnee committed Oct 6, 2009
  33. BUGFIX #4579: Translatable's call to new LanguageDropdownField() brok…

    …ed (from r87456)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@87458 467b73ca-7a2a-4603-9d3b-597d59a354a9
    sminnee committed Sep 29, 2009
  34. BUGFIX: was being passed to foreach without a check to see if it's an…

    … array or not.
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@86202 467b73ca-7a2a-4603-9d3b-597d59a354a9
    Jeremy Warne committed with sminnee Sep 14, 2009
  35. BUGFIX Fixed Member::sendInfo() assumptions that broke with an API ch…

    …ange in r84594
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@85779 467b73ca-7a2a-4603-9d3b-597d59a354a9
    halkyon committed with sminnee Sep 7, 2009