Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Feb 2, 2011
  1. Ingo Schommer Sam Minnée

    API CHANGE Using Controller::join_links() to construct links in Compl…

    chillu authored sminnee committed
    …exTableField and TableListField (partially merged from r88495, r96775)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@113321 467b73ca-7a2a-4603-9d3b-597d59a354a9
  2. Ingo Schommer Sam Minnée

    BUGFIX: Fixed Controller::join_links() handling of fragment identifie…

    chillu authored sminnee committed
    …rs (merged from r104580)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@113319 467b73ca-7a2a-4603-9d3b-597d59a354a9
  3. Ingo Schommer Sam Minnée

    MINOR Using SecurityToken in ViewableData->getSecurityID() (from r113…

    chillu authored sminnee committed
    …274)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@113312 467b73ca-7a2a-4603-9d3b-597d59a354a9
  4. Ingo Schommer Sam Minnée

    ENHANCEMENT Added Form->enableSecurityToken() as a counterpart to the…

    chillu authored sminnee committed
    … existing disableSecurityToken() (from r113284)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@113305 467b73ca-7a2a-4603-9d3b-597d59a354a9
  5. Ingo Schommer Sam Minnée

    MINOR Reverted commented out code (regression from r113293)

    chillu authored sminnee committed
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@113303 467b73ca-7a2a-4603-9d3b-597d59a354a9
  6. Ingo Schommer Sam Minnée

    BUGFIX Clear static marking caches on Hierarchy->flushCache() (from r…

    chillu authored sminnee committed
    …113277)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@113302 467b73ca-7a2a-4603-9d3b-597d59a354a9
  7. Ingo Schommer Sam Minnée

    BUGFIX Fixed ComplexTableField and TableListField GET actions against…

    chillu authored sminnee committed
    … CSRF attacks (with Form_SecurityToken->checkRequest()) (from r113276)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@113301 467b73ca-7a2a-4603-9d3b-597d59a354a9
  8. Ingo Schommer Sam Minnée

    MINOR Fixed HTTPRequest class usage (regression from r113293)

    chillu authored sminnee committed
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@113298 467b73ca-7a2a-4603-9d3b-597d59a354a9
  9. Ingo Schommer Sam Minnée

    API CHANGE Added security token to TableListField->Link() in order to…

    chillu authored sminnee committed
    … include it in all URL actions automatically. This ensures that field actions bypassing Form->httpSubmission() still get CSRF protection (from r113275)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@113297 467b73ca-7a2a-4603-9d3b-597d59a354a9
  10. Ingo Schommer Sam Minnée

    BUGFIX Using current controller for MemberTableField constructor in G…

    chillu authored sminnee committed
    …roup->getCMSFields() instead of passing in a wrong instance (Group) (from r113273)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@113294 467b73ca-7a2a-4603-9d3b-597d59a354a9
  11. Ingo Schommer Sam Minnée

    ENHANCEMENT Added SecurityToken to wrap CSRF protection via "Security…

    chillu authored sminnee committed
    …ID" request parameter (from r113272)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@113293 467b73ca-7a2a-4603-9d3b-597d59a354a9
  12. Ingo Schommer Sam Minnée

    BUGFIX Add PHPUnit includes to SapphireTest class (can be loaded outs…

    chillu authored sminnee committed
    …ide of TestRunner for static calls, in which case the PHPUnit autoloaders/includes aren't in place yet) (merged from r113156)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@113158 467b73ca-7a2a-4603-9d3b-597d59a354a9
  13. Ingo Schommer Sam Minnée

    BUGFIX Using mock controller in RestfulServiceTest to avoid problems …

    chillu authored sminnee committed
    …with missing require() calls for PHPUnit/Framework.php (performed in recently merged PHPUnitWrapper::init() which is never called for "nested" true HTTP calls within unit tests). Mostly merged from branches/2.4.
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@111837 467b73ca-7a2a-4603-9d3b-597d59a354a9
  14. Ingo Schommer Sam Minnée

    BUGFIX Renamed PHPUnit wrappers not to use underscores in classnames,…

    chillu authored sminnee committed
    … as this confuses ManifestBuilder prior to the 2.4 release
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@111836 467b73ca-7a2a-4603-9d3b-597d59a354a9
  15. Ingo Schommer Sam Minnée

    MINOR: added phpdoc to the new PHPUnitWrapper classes.

    chillu authored sminnee committed
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@111835 467b73ca-7a2a-4603-9d3b-597d59a354a9
  16. Ingo Schommer Sam Minnée

    ENHANCEMENT: refactored runTests, using the new phpunit wrapper classes.

    chillu authored sminnee committed
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@111834 467b73ca-7a2a-4603-9d3b-597d59a354a9
  17. Ingo Schommer Sam Minnée

    API-CHANGE: remove include which is not required.

    chillu authored sminnee committed
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@111833 467b73ca-7a2a-4603-9d3b-597d59a354a9
  18. Ingo Schommer Sam Minnée

    ENHANCEMENT: Created a phpunit wrapper class to ensure that Sapphire'…

    chillu authored sminnee committed
    …s test framework is capable of running unit tests, coverage report and retrieve clover-statistics for PHPUnit 3.4 and PHPUnit 3.5
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@111832 467b73ca-7a2a-4603-9d3b-597d59a354a9
  19. Ingo Schommer Sam Minnée

    ENHACENEMENT: Change behaviour of the MenufestBuilder to use spl_auto…

    chillu authored sminnee committed
    …load_register instead of traditional __autoload.
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@111831 467b73ca-7a2a-4603-9d3b-597d59a354a9
  20. Ingo Schommer Sam Minnée

    API CHANGE Don't reflect changes in File and Folder property setters …

    chillu authored sminnee committed
    …on filesystem before write() is called, to ensure that validate() applies in all cases. This fixes a problem where File->setName() would circumvent restrictions in File::$allowed_extensions (fixes #5693)
    
    API CHANGE Removed File->resetFilename(), use File->updateFilesystem() to update the filesystem, and File->getRelativePath() to just update the "Filename" property without any filesystem changes (emulating the old $renamePhysicalFile method argument in resetFilename())
    API CHANGE Removed File->autosetFilename(), please set the "Filename" property via File->getRelativePath()
    MINOR Added unit tests to FileTest and FolderTest (some of them copied from FileTest, to test Folder behaviour separately)
    ENHANCEMENT Added File::$allowed_extensions (backport from 2.4 to enable File->validate() security fix)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@108062 467b73ca-7a2a-4603-9d3b-597d59a354a9
  21. Ingo Schommer Sam Minnée

    BUGFIX: Don't allow direct access to PHP files in sapphire module, ex…

    chillu authored sminnee committed
    …cept for main.php and static-main.php (from r108023)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@108043 467b73ca-7a2a-4603-9d3b-597d59a354a9
  22. Ingo Schommer Sam Minnée

    MINOR Added querystring option to Makefile (from r103884)

    chillu authored sminnee committed
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@103897 467b73ca-7a2a-4603-9d3b-597d59a354a9
  23. Ingo Schommer Sam Minnée

    ENHANCEMENT Allowing TestRunner? to skip certain tests through the ?S…

    chillu authored sminnee committed
    …kipTests?=... GET paramete (merged from branches/2.3-nzct) (from r80646)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@103684 467b73ca-7a2a-4603-9d3b-597d59a354a9
  24. Ingo Schommer Sam Minnée

    MINOR: Fixed FileTest execution if the assets/ directory doesn't exis…

    chillu authored sminnee committed
    …t. (from r88353) (from r98086)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@103521 467b73ca-7a2a-4603-9d3b-597d59a354a9
  25. Sean Harvey Sam Minnée

    MINOR Fixed missing closing <div> in ContentController->successfullyi…

    halkyon authored sminnee committed
    …nstalled() (from r101254)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@101258 467b73ca-7a2a-4603-9d3b-597d59a354a9
  26. Ingo Schommer Sam Minnée

    BUGFIX Don't delete index.php after successful installation - in Cont…

    chillu authored sminnee committed
    …entController->deleteinstallfiles(). URL routing might rely on it without mod_rewrite.
    
    BUGFIX Require ADMIN permissions for ContentController->deleteinstallfiles() - together with retaining index.php this removed a vulnerability where unauthenticated users can disrupt mod_rewrite-less URL routing. (from r101227)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@101229 467b73ca-7a2a-4603-9d3b-597d59a354a9
  27. Ingo Schommer Sam Minnée

    BUGFIX Fixing Member_ProfileForm to validate for existing members via…

    chillu authored sminnee committed
    … Member_Validator to avoid CMS users to switch to another existing user account by using their email address (from r100704) (from r100717)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@100744 467b73ca-7a2a-4603-9d3b-597d59a354a9
  28. Ingo Schommer Sam Minnée

    MINOR Readded sapphire/thirdparty modules without svn:externals

    chillu authored sminnee committed
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@99765 467b73ca-7a2a-4603-9d3b-597d59a354a9
  29. Ingo Schommer Sam Minnée

    MINOR Fixed HTTPTest->testSetGetVar() (merged from r98409)

    chillu authored sminnee committed
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@98410 467b73ca-7a2a-4603-9d3b-597d59a354a9
  30. Ingo Schommer Sam Minnée

    MINOR Fixed HTTPTest->testSetGetVar() (merged from r98407)

    chillu authored sminnee committed
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@98408 467b73ca-7a2a-4603-9d3b-597d59a354a9
  31. Ingo Schommer Sam Minnée

    MINOR Added test case for Hierarchy::getDescendantIDList() which also…

    chillu authored sminnee committed
    … tests Hierarchy::loadDescendantIDListInto() (merged from r98369)
    
    MINOR Testing of grand-children items in HierarchyTest::testLoadDescendantIDListIntoArray() and HierarchyTest::testNumChildren() (merged from r98376)
    BUGFIX #5044 Hierarchy::loadDescendantIDListInto() now uses Object::getExtensionInstance('Hierarchy') instead of going through call(), as PHP 5.3 has issues converting references to values
    BUGFIX Fixed Hierarchy->loadDescendantIdList() to call setOwner() on the extension instance. This was necessary due to underlying Object/Extension changes in 2.4. (merged from r98403)
    MINOR Fixed HierarchyTest assertions around including grand children counts (merged from r98403)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@98405 467b73ca-7a2a-4603-9d3b-597d59a354a9
  32. Ingo Schommer Sam Minnée

    MINOR Fixed HTTPTest when invoked through dev/tests/all or with GET p…

    chillu authored sminnee committed
    …arameters (see r98373) (merged from r98383)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@98384 467b73ca-7a2a-4603-9d3b-597d59a354a9
  33. Ingo Schommer Sam Minnée

    API CHANGE HTTP::setGetVar() always returns absolute URLs. Use Direct…

    chillu authored sminnee committed
    …or::makeRelative() to make them relative again. (merged from r98373)
    
    API CHANGE HTTP::setGetVar() combines any GET parameters in PHP array notation (e.g. "foo[bar]=val") instead of replacing the whole array (merged from r98373)
    BUGFIX HTTP::setGetVar() uses parse_url() and http_build_query() to add query parameters to an existing URL, instead of doing its own regex-based parsing. This means existing GET parameters are correctly url encoded. (merged from r98373)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@98375 467b73ca-7a2a-4603-9d3b-597d59a354a9
  34. Andrew O'Neil Sam Minnée

    BUGFIX: Don't force SSL when running from CLI

    ajoneil authored sminnee committed
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@98273 467b73ca-7a2a-4603-9d3b-597d59a354a9
  35. Ingo Schommer Sam Minnée

    BUGFIX Disabled ?debug_profile=1 on live environment types (merged fr…

    chillu authored sminnee committed
    …om r80057)
    
    git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@98230 467b73ca-7a2a-4603-9d3b-597d59a354a9
Something went wrong with that request. Please try again.