Permalink
Commits on Sep 24, 2018
  1. FIX Don't flush manifests in tests by default

    chillu committed Sep 24, 2018
    It's massively slowing down test execution,
    particularly for rapid execution through test-driven-development (TDD)
Commits on Sep 17, 2018
  1. Merge pull request #8361 from open-sausages/pulls/4/release-docs

    chillu committed Sep 17, 2018
    Release process docs
Commits on Sep 12, 2018
  1. DOCS Clarified latest vs. next

    chillu committed Sep 12, 2018
  2. DOCS Don't mention 5.3, its unsupported

    chillu committed Sep 5, 2018
  3. DOCS Release support clarification

    chillu committed Sep 5, 2018
    See #8189
Commits on Sep 5, 2018
Commits on Sep 4, 2018
  1. Make sure that CMS requests disable caching

    chillu committed Sep 4, 2018
    Original author: @dhensby
    
    Forward port from 3.7 fix at #8318
Commits on Jul 30, 2018
  1. Merge pull request #8261 from open-sausages/pulls/4/secure-remember-m…

    chillu committed Jul 30, 2018
    …e-cookie
    
    NEW Option for secure "remember me" cookie
  2. NEW Option for secure "remember me" cookie

    chillu authored and dhensby committed Jul 12, 2018
    Fixes #8234
Commits on Jul 26, 2018
  1. Merge pull request #8288 from open-sausages/pulls/4/recommend-install…

    chillu committed Jul 26, 2018
    …-upgrader-with-phar
    
    BUG Recommend install of upgrader with PHAR exec.
Commits on Jul 23, 2018
  1. Properly deprecate HTTP.cache_control

    chillu authored and dhensby committed Jul 19, 2018
  2. Removed unused classes

    chillu authored and dhensby committed Jul 18, 2018
  3. Add $maxAge arg for caching API

    chillu authored and dhensby committed Jul 18, 2018
    See #8272
  4. Test coverage for session data change

    chillu authored and dhensby committed Jul 18, 2018
  5. Fix tests on unset session data

    chillu authored and dhensby committed Jul 18, 2018
    Thanks Robbie!
  6. BUG Lazy session state (fixes #8267)

    chillu authored and dhensby committed Jul 18, 2018
    Fixes regression from 3.x, where sessions where lazy started as required:
    Either because an existing session identifier was sent through with the request,
    or because new session data needed to be persisted as part of the request execution.
    
    Without this lazy starting, *every* request will get a session,
    which makes all those responses uncacheable by HTTP layers.
    
    Note that 4.x also changed the $data vs. $changedData payloads:
    In 3.x, they both contained key/value pairs.
    In 4.x, $data contains key/value, while $changedData contains key/boolean to declare isChanged.
    While this reduces duplication in the class, it also surfaced a bug which was latent in 3.x:
    When an existing session is lazily resumed via start(), $data is set back to an empty array.
    In 3.x, any changed data before this point was *also* retained in $changedData,
    ensuring it gets merged into existing $_SESSION data.
    In 4.x, this clears out data - hence the need for a more complex merge logic.
    
    Since isset($this->data) is no longer an accurate indicator of a started session,
    we introduce a separate $this->started flag.
    
    Note that I've chosen not to make lazy an opt-in (e.g. via start($request, $lazy=false)).
    We already have a distinction between lazy starting via init(), and force starting via start().
Commits on Jul 20, 2018
  1. Merge pull request #8269 from open-sausages/pulls/4/session-lazy

    chillu committed Jul 20, 2018
    BUG Lazy session state (fixes #8267)
  2. Test coverage for session data change

    chillu committed Jul 18, 2018
Commits on Jul 19, 2018
  1. Fix tests on unset session data

    chillu committed Jul 18, 2018
    Thanks Robbie!
  2. BUG Lazy session state (fixes #8267)

    chillu committed Jul 18, 2018
    Fixes regression from 3.x, where sessions where lazy started as required:
    Either because an existing session identifier was sent through with the request,
    or because new session data needed to be persisted as part of the request execution.
    
    Without this lazy starting, *every* request will get a session,
    which makes all those responses uncacheable by HTTP layers.
    
    Note that 4.x also changed the $data vs. $changedData payloads:
    In 3.x, they both contained key/value pairs.
    In 4.x, $data contains key/value, while $changedData contains key/boolean to declare isChanged.
    While this reduces duplication in the class, it also surfaced a bug which was latent in 3.x:
    When an existing session is lazily resumed via start(), $data is set back to an empty array.
    In 3.x, any changed data before this point was *also* retained in $changedData,
    ensuring it gets merged into existing $_SESSION data.
    In 4.x, this clears out data - hence the need for a more complex merge logic.
    
    Since isset($this->data) is no longer an accurate indicator of a started session,
    we introduce a separate $this->started flag.
    
    Note that I've chosen not to make lazy an opt-in (e.g. via start($request, $lazy=false)).
    We already have a distinction between lazy starting via init(), and force starting via start().
Commits on Jul 5, 2018
  1. Merge pull request #8223 from dhensby/pulls/4.0/remove-email-from-psw…

    chillu committed Jul 5, 2018
    …drecovery
    
    FIX remove personal information from password reset confirmation screen
  2. Merge pull request #8233 from dhensby/pulls/4.2/caching-fixes

    chillu committed Jul 5, 2018
    HTTP Caching fixes :/
Commits on Jul 2, 2018
  1. Merge pull request #8200 from open-sausages/pulls/4/versioning-doc-up…

    chillu committed Jul 2, 2018
    …date
    
    Refactoring versioning doc
  2. DOCS Minor versioned edits

    chillu committed Jul 2, 2018
    [ci skip]
Commits on Jun 27, 2018
  1. Merge pull request #8143 from open-sausages/pull/4/refactoring-upgrad…

    chillu committed Jun 27, 2018
    …ing-doc
    
    The definitive upgrade guide to SilverStripe 4
  2. Removed duplicate upgrade instructions

    chillu committed Jun 25, 2018
    They're already present in the new upgrading guide
    
    Folded upgrading "list of changes" into 4.0.0 guide
    
    They duplicate each other, and create confusion in the upgrading
    doc because there's *both* an "overview" of changes at the top,
    and "important changes" at the bottom - why are they at the bottom when they're important?
    
    Added "skip" and "continue" anchor links
    
    [ci skip]
Commits on Jun 25, 2018
  1. DOCS More resilient example domain

    chillu committed Jun 25, 2018
    myapp.com is owned, example.com is specifically reserved for documentation use cases:
    https://en.wikipedia.org/wiki/Example.com
    
    [ci skip]
Commits on Jun 24, 2018
  1. DOCS Consistent app/ folder and composer use

    chillu committed Jun 24, 2018
    - Stronger wording around "use composer"
    - Consistent domain and email address naming
    - Removed example for publishing non-composer modules (those shouldn't be encouraged)
    - Removed instructions for installing modules from archives
    
    [ci skip]
  2. DOCS Vendor paths for test docs

    chillu committed Jun 24, 2018
    [ci-skip]
Commits on Jun 18, 2018
  1. Merge pull request #8195 from dhensby/pulls/4.2/cache-default

    chillu committed Jun 18, 2018
    FIX Default cache state should be `no-cache`