Skip to content

Installer turns display_errors on, but then warns about it being on regardless of php.ini setting #2479

Closed
halkyon opened this Issue Oct 3, 2013 · 2 comments

3 participants

@halkyon
SilverStripe Ltd. member
halkyon commented Oct 3, 2013

There's a check in the installer for display_errors which gives a warning if it's turned on. Even if it's turned off in php.ini it'll still show up this warning because this line of code makes the check useless:

https://github.com/silverstripe/silverstripe-framework/blob/3.1/dev/install/install.php5#L22

Suggested fix is to check the original value before display_errors is set to "On" by the installer.

@chillu
SilverStripe Ltd. member
chillu commented Oct 3, 2013

Hah yeah that's a doozie - we should check the original value. Pull request? ;)

@halkyon
SilverStripe Ltd. member
halkyon commented Oct 3, 2013

I'll take care of this.

@halkyon halkyon added a commit to halkyon/silverstripe-framework that referenced this issue Oct 3, 2013
@halkyon halkyon BUG Fixing installer not checking display_errors correctly.
Fixes issue #2479. Installer sets display_errors on, but it checks
the changed value and not the original one set in php.ini.
1fb10ee
@halkyon halkyon added a commit to halkyon/silverstripe-framework that referenced this issue Oct 3, 2013
@halkyon halkyon BUG Fixing installer not checking display_errors correctly.
Fixes issue #2479. Installer sets display_errors on, but it checks
the changed value and not the original one set in php.ini.
dd49834
@simonwelsh simonwelsh closed this Mar 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.