Installer turns display_errors on, but then warns about it being on regardless of php.ini setting #2479

Closed
halkyon opened this Issue Oct 3, 2013 · 2 comments

Comments

Projects
None yet
3 participants
@halkyon
Member

halkyon commented Oct 3, 2013

There's a check in the installer for display_errors which gives a warning if it's turned on. Even if it's turned off in php.ini it'll still show up this warning because this line of code makes the check useless:

https://github.com/silverstripe/silverstripe-framework/blob/3.1/dev/install/install.php5#L22

Suggested fix is to check the original value before display_errors is set to "On" by the installer.

@chillu

This comment has been minimized.

Show comment
Hide comment
@chillu

chillu Oct 3, 2013

Member

Hah yeah that's a doozie - we should check the original value. Pull request? ;)

Member

chillu commented Oct 3, 2013

Hah yeah that's a doozie - we should check the original value. Pull request? ;)

@halkyon

This comment has been minimized.

Show comment
Hide comment
@halkyon

halkyon Oct 3, 2013

Member

I'll take care of this.

Member

halkyon commented Oct 3, 2013

I'll take care of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment