Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

UploadField iframe incorrect height #2862

Open
kinglozzer opened this Issue Feb 18, 2014 · 3 comments

Comments

Projects
None yet
5 participants
Owner

kinglozzer commented Feb 18, 2014

Spotted this issue when using the ‘focuspoint’ module, doesn’t seem to happen with just the usual form fields - only when fields are added (see screenshot).

Note that this can only be partially observed post 3.1.2 - fitHeight() is triggered twice, the second time calculates the correct height (#2863).

The issue is caused by setting the form’s width to be 98% here. We’re setting this width after we’ve calculated the height - meaning that the calculated height may be (and is) wrong. Closing and re-opening the edit form will fix it, as it can then calculate the height with the width already set to 98%.

I’m not really sure why this width is set at all, but either removing it or moving it to before we find the form’s height fixes the issue.

screen shot 2014-02-18 at 16 33 53

@simonwelsh simonwelsh added the 3.1 label Mar 15, 2014

@halkyon halkyon closed this in 58f8c29 Sep 25, 2014

halkyon added a commit that referenced this issue Sep 25, 2014

Merge pull request #2866 from kinglozzer/2862-uploadfield-editform-he…
…ight

FIX: UploadField height calculation fix (fixes #2862 & #2863)
Owner

kinglozzer commented Sep 16, 2016 edited

This bug has re-surfaced, confirmed in 3.4 but IIRC it’s also present in 3.2 and 3.3. Original issue above suggested this only happens when extra fields are added to the form, but I’ve confirmed the issue happens without that, for example:

screen shot 2016-09-16 at 10 09 02

@kinglozzer kinglozzer reopened this Sep 16, 2016

Owner

dhensby commented Sep 16, 2016

It's the alert that's causing extra height it seems

@tractorcow tractorcow added the type/bug label Nov 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment