Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

UploadField iframe incorrect height #2862

Closed
kinglozzer opened this Issue · 0 comments

2 participants

@kinglozzer
Collaborator

Spotted this issue when using the ‘focuspoint’ module, doesn’t seem to happen with just the usual form fields - only when fields are added (see screenshot).

Note that this can only be partially observed post 3.1.2 - fitHeight() is triggered twice, the second time calculates the correct height (#2863).

The issue is caused by setting the form’s width to be 98% here. We’re setting this width after we’ve calculated the height - meaning that the calculated height may be (and is) wrong. Closing and re-opening the edit form will fix it, as it can then calculate the height with the width already set to 98%.

I’m not really sure why this width is set at all, but either removing it or moving it to before we find the form’s height fixes the issue.

screen shot 2014-02-18 at 16 33 53

@kinglozzer kinglozzer referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@kinglozzer kinglozzer referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@simonwelsh simonwelsh added the 3.1 label
@halkyon halkyon closed this in 58f8c29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.