BUG UploadField hijacking return key

[micmania1]

The bug was originally reported on stackoverflow and I can confirm it exists in the latest stable release of 3.1.

"I have page/form in the SS 3 CMS that has an uploadfield on it - when I hit enter on other fields the popup to attach a file automatically shows, how can I stop this behaviour?"
http://stackoverflow.com/questions/23988952/silverstripe-3-uploadfield-stop-upload-popup-appearing-when-enter-is-pressed

To reproduce
Create a Page/DataObject.
Add a TextField and UploadField
Focus on the TextField then press the return key.

If you haven't uploaded an image, it will trigger the modal to select a file.
If you have uploaded an image it will trigger the edit form of the upload field.

[pedro2555]

@micmania1 Can you confirm this against 3.1?

I could not reproduce it. Maybe a CMS issue?

[patricknelson]

My bug report at silverstripe/silverstripe-cms#1288 (corrected for CMS repository) may be a duplicate of this. However, work is needed on both repositories, it appears. Ping @kinglozzer

[patricknelson]

@micmania1 @pedro2555 @kinglozzer

Ok, this was a combined fix applied to 3.1 on the CMS and framework, since the general underlying issue affected both repositories. See below for legend.

• CMS:
  • Issue: JavaScript is clicking first button in form when pressing "enter" key. silverstripe-cms#1288
  • PR: FIX (partial) for #1288 where non-submit buttons are being activated on "enter" key press. silverstripe-cms#1290
• Framework:
  • Issue: BUG UploadField hijacking return key #3181 (you are here)
  • PR: FIX (partial) for #3181 where non-submit buttons are being activated on "enter" key press. #4651

[patricknelson]

@kinglozzer This issue should be since it has now been resolved by #4662 👍

I duplicated it and then fixed it after submitting my CMS issue at silverstripe/silverstripe-cms#1288