Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC Drop core support for non-PDO based DBConnectors #6502

Closed
dhensby opened this issue Jan 13, 2017 · 3 comments
Closed

RFC Drop core support for non-PDO based DBConnectors #6502

dhensby opened this issue Jan 13, 2017 · 3 comments

Comments

@dhensby
Copy link
Contributor

dhensby commented Jan 13, 2017

We currently maintain both "legacy" non-PDO DBConnectors and PDO based DBConnectors. This adds to our maintenance burden for less eddicient DB drivers.

It also makes improving performance more tricky as often the non-PDO based drivers won't implement features that help us be a bit more intelligent about what we pull out from the database - this can be a problem with seeking.

If we merge the patch @kinglozzer has written in #6501 there will be significant performance penalties for using non-PDO drivers as it is.

@kinglozzer
Copy link
Member

kinglozzer commented Jan 13, 2017

I suppose we’ll need to consider whether PDO drivers come installed with PHP, and how hard it is to install them if not. I’d also weigh that up against whether devs already need to install extra software for other drivers anyway.

If we merge the patch @kinglozzer has written in #6501 there will be significant performance penalties for using non-PDO drivers as it is.

Just to clarify: in the context of that PR, SQLite3 is the one that suffers performance-wise currently, and MSSQL won’t work at all without some changes (to implement seek()). MySQL & PostgreSQL are both fine.


Edit: this issue is no longer relevant for the linked PR, but still should be considered IMO.

@sminnee
Copy link
Member

sminnee commented Jun 27, 2017

My view is that we shouldn't do this.

  • Work on dbal would supercede this and I think leaving status quo until we address that is fine.
  • The problems you raise are worse in PDO than the non-PDO connectors — PDO is the one that has the seek problem.

@dhensby
Copy link
Contributor Author

dhensby commented Jul 5, 2017

agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants