7595 data query apply relation #970
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e003796. Conflicts: tests/travis/_ss_environment.php
…g on the name of the admin and greeting message. position and height were being set inline so added !important to override this.
FIX Director::is_absolute_url() now ignores query string
BUG: Allow using instances for search filters.
GridField uses createTag() which is marked for deprecation, rather than have it used as the cornerstone of generating FormField templates, use it as a helper in case fields generate HTML tags from PHP.
Deprecation cleanup
Update javascript/GridField.js
These have been moved to a module called "legacytablefields" located at https://github.com/silverstripe-labs/legacytablefields
Removed h2 from outside breadcrumbs, and put it within the breadcrumbs div Goes alon the cms commit 4fab9b8
The original intention of this method was to be a rewrite check by the installer, but it doesn't belong in DatabaseAdmin, nor is it used by the installer anymore, since the rewrite test is done by the installer directly.
Removing redundant DatabaseAdmin::testinstall()
We might decide to use it for other submissions than EditForm.
Conflicts: admin/code/CMSProfileController.php composer.json tests/model/DataObjectTest.php
…rrect-bc-nesting BUG Incorrect html nesting of breadcrumbs
…itform-validation Future-proof the submitForm for use with forms without validation.
Makes the editor API more flexible by triggering generic JS events that can be used from entwine. This makes it easier to add event handlers to the editor and cleans up the initialisation call from unrelated code. The patching code also forwards editor changes to the textarea field, which in perspective will allow the changetracker to react to changes in this field as they happen.
… the relations name as an alias to the SQL query
|
Hey Roland, thanks for bringing this up again, but I have a couple of questions:
Closing off for now, please reopen if appropriate. |
|
Had another look at the change, and dug up your original pull request (#756). "We want to get away from duplication logic that's close to the model in controllers, the dot notation is a good example of that. We now allow disjunctive grouping of filters, see #808. Can I suggest that you try to rework your patch to use it? Haven't tried this myself, but the general idea is that you can just pass through field names with dot notation and it'll do its thing. If it doesn't, we need to fix the underlying DataList bugs first." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has_many relations are also searched in the GridFieldAddExistingAutocompleter if they are defined in searchableFields.