Update i18nTextCollector to collect strings also from themes

[xini]

Fixes #8491

[michalkleiner]

Looks ok from my perspective, thanks for the tweaks!

I'm not too fussed if this particular PR goes to 4.12 as a bugfix or to 4 as an enhancement, what do you think @GuySartorelli?

P.S. Squash will be needed

[michalkleiner]

I'm not too fussed if this particular PR goes to 4.12 as a bugfix or to 4 as an enhancement, what do you think @GuySartorelli?

Based on Guy's comment on #10686 I suggest this also targets 4. Then we can get both in as enhancements for 4.13 which is not too far away.

[xini]

rebased and squashed.

[xini]

the tests didn't trigger when I rebased this. can you please trigger them manually?

[GuySartorelli]

There's no way that I'm aware of to trigger tests manually on a PR. Try pushing to the branch again.

[GuySartorelli]

Sorry, I haven't had time to look at this again - at the very least this will need to target the 5 branch and be rebased. Can you please do that? I'll try make time to look at this properly over the next couple of weeks.

[xini]

Thanks @GuySartorelli. This is now rebased and squashed.

[GuySartorelli]

Please also add some unit tests to validate that this new functionality actually collects translations from themes as expected.

Sorry there are so many changes I didn't mention last time - I should have caught these the first time around.

[GuySartorelli]

I've created silverstripe/developer-docs#263 which will document this change.

There have been a lot of changes since then

[xini]

Hey @GuySartorelli, I think this is now all cleaned up I have added a test as well. Let me know if you're happy with this and I'll squash the commits. Thank you!

[GuySartorelli]

That's awesome, thank you! I haven't run it locally yet which I'll do before merging, but given the test is passing I'm pretty confident it works. The code looks good from a visual-inspection. Please go ahead and squash it, I'll try to make time either later today or tomorrow to run it locally before merging.

Changes have been made

[xini]

Done, thank you!

[GuySartorelli]

Works great locally, thank you! Between this and the ORM change, this has been a significant contribution.

[xini]

Thank you! It has been bugging me since 4.0, when the themes functionality was removed... 🙃 And with a few non-english projects over the last few months I finally had enough... 😉