MINOR: 2 changes to ModelAdmin styling (see #6782) #128

Closed
wants to merge 55 commits into
from

Conversation

Projects
None yet
@ghost

ghost commented Dec 16, 2011

  1. styling to also apply for dropdowns & changing structural class to cms-*
  2. dealing with long labels and buttons
@chillu

This comment has been minimized.

Show comment Hide comment
@chillu

chillu Dec 16, 2011

Member

Needs some more thought on icon styling, they look worse with this changeset - see http://open.silverstripe.org/ticket/6782 for details

Member

chillu commented Dec 16, 2011

Needs some more thought on icon styling, they look worse with this changeset - see http://open.silverstripe.org/ticket/6782 for details

chillu and others added some commits Dec 16, 2011

BUGFIX Better handling of multibyte strings in LimitCharacters(), rem…
…oved code duplication by more flexible base implementation at StringField->LimitCharacters() (Merge pull request #121 from edlund/sapphire)
Merge pull request #62 from howardgrigg/patch-1
MINOR Correct BreadCrumb include
ENHANCEMENT: scale cms dialog popups based on browser. BUGFIX: #6760
…ensure scrolling is supported in cms dialogs
@chillu

This comment has been minimized.

Show comment Hide comment
@chillu

chillu Dec 17, 2011

Member

body.ArrayData naming is a bug which should be fixed (which is surprisingly hard!) - we shouldn't rely on that for any styling.

body.ArrayData naming is a bug which should be fixed (which is surprisingly hard!) - we shouldn't rely on that for any styling.

simonwelsh and others added some commits Dec 17, 2011

ENHANCEMENT Allow ClassManifest to handle classes with namespaces, or…
… that extend classes in namspaces or that implement interfaces in namespaces.
ENHANCEMENT: keep Cookie::forceExpiry() consistent with Cookie::set()…
… for preventing cookies from not being deleted. Fixes #56
Merge pull request #133 from simonwelsh/54_fixes
MINOR Change error reporting level to explicitly exclude values rather t...
Merge pull request #131 from halkyon/master
Nice debug formatting for ArrayList and DataList

stojg and others added some commits Dec 8, 2011

Revert "MINOR Use json_decode() instead of the Services_JSON class if…
… the function exists." - it breaks assumptions around Convert::json2array() only converting the *first* level of an object structure into an array, which in turn fails CMSMainTest and LeftAndMainTest (as well as some UI functionality relying on it). In order to introduce this change we have to fix these issues in a backwards compatible manner.

This reverts commit 3a006b7.
@chillu

This comment has been minimized.

Show comment Hide comment
@chillu

chillu Dec 18, 2011

Member

@simonwelsh This change is breaking the (admittedly faulty) API. While I think the change in general is a good idea (mainly for performance reasons), it needs more testing (both fixing UTs and checking JS like batch actions).

Member

chillu commented on 05d19d9 Dec 18, 2011

@simonwelsh This change is breaking the (admittedly faulty) API. While I think the change in general is a good idea (mainly for performance reasons), it needs more testing (both fixing UTs and checking JS like batch actions).

This comment has been minimized.

Show comment Hide comment
@sminnee

sminnee Dec 18, 2011

Member

Which tests does it break?

Member

sminnee replied Dec 18, 2011

Which tests does it break?

This comment has been minimized.

Show comment Hide comment
@chillu

chillu Dec 18, 2011

Member

CMSMainTest and LeftAndMainTest

Member

chillu replied Dec 18, 2011

CMSMainTest and LeftAndMainTest

Anselm Christophersen added some commits Dec 18, 2011

@chillu

This comment has been minimized.

Show comment Hide comment
@chillu

chillu Dec 20, 2011

Member

Closing off, was superseded by pull request #139

Member

chillu commented Dec 20, 2011

Closing off, was superseded by pull request #139

@chillu chillu closed this Dec 20, 2011

stojg pushed a commit to stojg/sapphire that referenced this pull request Oct 30, 2012

Merge pull request #128 from ryanwachtl/silverstripe-cms
---

When page Title field is changed, adds an "Update URL" button. Also updates the panel breadcrumb and tree after the Title field changes.

AntiSol added a commit to petpack/sapphire that referenced this pull request Nov 25, 2014

AntiSol added a commit to petpack/sapphire that referenced this pull request Dec 8, 2014

github #128: fix broken assumption that File filenames are relative (…
…in core! WTF?!?), break with Silverstripe philosophy by doing things like checking whether a file exists before trying to open it)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment