Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

FIX Remove check for existing BASE_PATH in ParameterConfirmationToken #2253

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Owner

hafriedlander commented Jul 21, 2013

ParameterConfirmationToken#pathForToken would check for BASE_PATH being set
before trying to determine base path itself. However this just caused
problems, since there were several entry points to the method, some where
BASE_PATH might have been set, some where it wasnt

(Twin of 2.4 pull request #2252)

Hamish Friedlander FIX Remove check for existing BASE_PATH in ParameterConfirmationToken
ParameterConfirmationToken#pathForToken would check for BASE_PATH being set
before trying to determine base path itself. However this just caused
problems, since there were several entry points to the method, some where
BASE_PATH might have been set, some where it wasnt
3551ee6
Owner

sminnee commented Jul 21, 2013

Rejected as unworkable, see original issue.

@sminnee sminnee closed this Jul 21, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment