Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

BUGFIX, API CHANGE: Enable setting the DB timezone from the environment. #239

Merged
merged 1 commit into from Mar 12, 2012

Conversation

Projects
None yet
2 participants
Contributor

oddnoc commented Mar 11, 2012

  • It was possible to set the database time zone from $databaseConfig, but not if you were using ConfigureFromEnv.
  • Introduces a new constant, SS_DATABASE_TIMEZONE
BUGFIX, API CHANGE: Enable setting the DB timezone from the environment.
- It was possible to set the database time zone from $databaseConfig, but not if you were using ConfigureFromEnv.
- Introduces a new constant, SS_DATABASE_TIMEZONE
Owner

halkyon commented Mar 11, 2012

Seems good, although the only database adapter supporting this is MySQLDatabase. As a related task, we should look into adding timezone support (if possible) to the other adapters too.

Contributor

oddnoc commented Mar 12, 2012

Right. This is tangentially related to the work I'm doing getting the test suite to use a well-defined time zone for time & date calculations. Right now many of them assume the NZ timezone, so I'm converting them all to UTC. Some of this will require some fixes to the DB adapters, as well.

Owner

halkyon commented Mar 12, 2012

@oddnoc Sounds good :)

halkyon added a commit that referenced this pull request Mar 12, 2012

Merge pull request #239 from oddnoc/ConfigureFromEnv-timezone
API CHANGE: Enable setting the DB timezone from the environment.

@halkyon halkyon merged commit b2d16fd into silverstripe:master Mar 12, 2012

stojg added a commit to stojg/sapphire that referenced this pull request Feb 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment