...hion to the one for JS/Css files. This is mostly for enabling long etag headers on assets and therefore improve caching performance.
Also, this should probably use Controller::join_links() as there's no reason why Filename can't contain query parameters already.
yep, I'll do that too,
I just didn't have time this week to look at writing tests.
Hopefully next week
MINOR Enable the addition of a cache buster for assets, in a similar …
…fashion to the one for JS/Css files
MINOR Use Controller::join_links when appending cache buster param
MINOR Updated unit tests for cache buster param
All changes suggested by @simonwelsh now integrated
Still some test failures happening. Could you look at those @patbolo ? :)
May I suggest also using $this->LastEdited rather than filemtime? filemtime will touch the disk whereas $this->LastEdited should already be loaded in the DataObject (and in RAM) by this point.
See my suggested changes here: #2931
No updates in 5 months, so I'm closing. If you fix this up, feel free to reopen the pull request.