BUG Fixes a regexp that could never be matched and was wrong anyway. #2404

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@SaschaSchwarz

Regex in getFinalisedQuery() would not match "column" in ' "table".'column" ' as it's supposed to.

I blew this PR the other day - but I think it's fine now.

SaschaSchwarz Fixes a regexp that could never be matched and was wrong anyway.
Comment and code in GetFinalizedQuery() do not match.
This PR solves an issue in our project where the Query would not contain left joins for addtional tables needed.
86ab58f
@simonwelsh

Tests? :)

@halkyon
SilverStripe Ltd. member

+1. Tests please? :)

@simonwelsh

No updates in 6 months, so closing. If you add the tests, feel free to reopen.

@simonwelsh simonwelsh closed this Mar 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment