Skip to content

Fixing TemplateManifest breaking tests run one after another. #2600

Closed
wants to merge 1 commit into from

4 participants

@halkyon
SilverStripe Ltd. member
halkyon commented Oct 24, 2013

Currently if you run SSViewerTest there will be test errors
on subsequent runs of the same tests. Removing (seemingly)
unnecessary template manifest manipulation seems to fix this.

@halkyon halkyon Fixing TemplateManifest breaking tests run one after another.
Currently if you run SSViewerTest there will be test errors
on subsequent runs of the same tests. Removing unnecessary
template manifest manipulation seems to fix this.
58ae433
@chillu
SilverStripe Ltd. member
chillu commented Oct 24, 2013

@hafriedlander You introduced this with d2650bb, any idea why it was necessary back then, but seems to pass now without the modification?

@hafriedlander
SilverStripe Ltd. member

I don't see how the tests pass with this removed. The testLayout method needs the layouttest theme to be active for the test to pass, and this just reverts to using the default theme.

@halkyon
SilverStripe Ltd. member
halkyon commented Oct 24, 2013

It definitely loads the Shortcodes template in somehow ;-) this might be an indication of a greater problem in SSViewerTest.

@halkyon
SilverStripe Ltd. member
halkyon commented Oct 31, 2013

@hafriedlander Could this be because all the templates get loaded anyway? Especially because the theme is just embedded straight in the framework, in framework/tests/view/themes/layouttest

@chillu
SilverStripe Ltd. member
chillu commented Dec 13, 2013

@hafriedlander @halkyon Any update on this?

@simonwelsh simonwelsh added the 3.1 label Mar 15, 2014
@halkyon halkyon closed this Sep 25, 2014
@halkyon halkyon deleted the halkyon:ssviewer_test_fix branch Sep 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.