BUGFIX: removing reliance on Parent::getCMSFields #2860

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

sunnysideup commented Feb 17, 2014

Removing reliance on the parent::getCMSFields within the Member::getCMSFields method for the following reasons:

  • in line with the way CMS Fields are added by other core model classes such as Folder, File, and Group, none of which use parent::getCMSFields.
  • more efficient (not adding a whole bunch of fields and then removing them again)
  • updateCMSFields extension called only once
  • Less intimidating Member Fields with the less commonly used fields out of the way in separate tab (locale settings).

Original ticket: #2827

BUGFIX: removing reliance on Parent::getCMSFields
Removing reliance on the parent::getCMSFields within the Member::getCMSFields method for the following reasons:

- in line with the way CMS Fields are added by other core model classes such as Folder, File, and Group, none of which use parent::getCMSFields.

- more efficient (not adding a whole bunch of fields and then removing them again)

- updateCMSFields extension called only once

- Less intimidating Member Fields with the less commonly used fields out of the way in separate tab (locale settings).

Original ticket: #2827
Contributor

tractorcow commented Feb 17, 2014

Some small requests:

Still to confirm if we want to target 3.1 or master for this, so hang tight!

Contributor

simonwelsh commented Feb 18, 2014

This cannot go in 3.1. It is far too large of a behaviour change.

@simonwelsh simonwelsh closed this Mar 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment