Update extend-cms-interface #2869

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
6 participants

Add mention of breadth-first selection when it comes to template selection priority.

@Tangdongle Tangdongle Update extend-cms-interface
Add mention of breadth-first selection when it comes to template selection priority.
27dfca1

@chillu chillu commented on an outdated diff Mar 2, 2014

docs/en/howto/extend-cms-interface.md
@@ -17,7 +17,13 @@ guide on [CMS Architecture](../reference/cms-architecture).
If you place a template with an identical name into your application template
directory (usually `mysite/templates/`), it'll take priority over the built-in
-one.
+one.
+
+One thing to remember when overriding a template with a custom one, such as in a module, priority is determined
+by a breadth-first search, so any template on a deeper level of the file heirarchy will take
@chillu

chillu Mar 2, 2014

Owner

Spelling error ("heirarchy")

Contributor

simonwelsh commented Mar 15, 2014

Can you squash your commits please?

@simonwelsh simonwelsh added docs master 3.1 and removed master labels Mar 15, 2014

Contributor

camfindlay commented Jul 3, 2014

I'm wondering is squashing commits is something we can help with for doc contributors who are more interested in technical writing and small improvements to docs (as opposed to devs that are changing docs based on their actual code changes?) - less barriers and hoops technical writers have to jump through might mean more timely improvements to docs? I see a lot of PRs end up just getting left even if some good incremental improvements have been made after a bit of discussion on github. Interested in how we might improve this process a bit for the different types of doc writers.

Contributor

stevie-mayhew commented Jul 3, 2014

I like the approach which @tractorcow took with #3233 - this reduces some of the need for non-technical submissions to follow the technical steps which are in some cases a barrier to submissions being completed.

"Well, there's another solution. In some other modules I've contributed to, the collaborator / owner doesn't directly merge anything, but will fork them locally, squash / edit them, and push them up manually. Maybe rather than getting contributors to do that we could do a bit of the overhead ourselves?"

@camfindlay camfindlay commented on the diff Jul 3, 2014

docs/en/howto/extend-cms-interface.md
@@ -17,7 +17,13 @@ guide on [CMS Architecture](../reference/cms-architecture).
If you place a template with an identical name into your application template
directory (usually `mysite/templates/`), it'll take priority over the built-in
-one.
+one.
+
+One thing to remember when overriding a template with a custom one, such as in a module, priority is determined
@camfindlay

camfindlay Jul 3, 2014

Contributor

@Tangdongle is there a better way of wording this? I'm not quite following this.

Owner

halkyon commented Sep 25, 2014

No activity in a long time. Closing.

halkyon closed this Sep 25, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment