Making Director::test() ignore URL Anchors #2901

Merged
merged 1 commit into from Mar 14, 2014

Projects

None yet

2 participants

Owner
dhensby commented Feb 26, 2014

Anchors should never make it to the server when they are in the browser URL bar, however tests are slightly different and some Link() functions may return a URL anchor. Instead of every test checking a link and stripping the anchor, I feel the Director::test() function should strip them off.

@dhensby dhensby Making Director::test() ignore URL Anchors
Anchors should never make it to the server when they are in the browser URL bar, however tests are slightly different and some `Link()` functions may return a URL anchor. Instead of every test checking a link and stripping the anchor, I feel the Director::test() function should strip them off.
5e6c1b9
@simonwelsh simonwelsh merged commit d1befdd into silverstripe:master Mar 14, 2014

1 check passed

default Scrutinizer: 4548 added/modified code elements — Travis: Passed
Details
Owner
dhensby commented Mar 14, 2014

Thanks

@dhensby dhensby deleted the dhensby:director-test branch May 6, 2014
Owner
dhensby commented Sep 2, 2014

@simonwelsh / @chillu - can we get this into 3.1, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment