Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

BUG Upload: file versioning uses illegal underscore in filename #2921

Merged
merged 1 commit into from Sep 24, 2014

Conversation

Projects
None yet
3 participants
Contributor

JayDevlin commented Mar 4, 2014

Bug:
Uploaded files without a suffix can not be found in filesystem because file versioning appends an underscore to the filename which is filtered out by FileNameFilter in File->setName().

Refactoring:

  • explode('.', 'UploadTest-testUpload.tar.gz')
  • use first array value "UploadTest-testUpload" to version the file to "UploadTest-testUpload2"
  • append the rest of the array again: "UploadTest-testUpload2.tag.gz"

Also:

  • removed .tar.gz/.tar.bz2 exception -- covered by see above
  • removed underscore exception -- covered by FileNameFilter
    #2904
Contributor

simonwelsh commented Mar 15, 2014

This needs to be rebased.

@simonwelsh simonwelsh added the 3.1 label Mar 15, 2014

halkyon added a commit that referenced this pull request Sep 24, 2014

Merge pull request #2921 from JayDevlin/2904-upload-file-versioning
BUG Upload: file versioning uses illegal underscore in filename

@halkyon halkyon merged commit 6d12cf3 into silverstripe:3.1 Sep 24, 2014

1 check passed

default Scrutinizer: No new issues — Travis: Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment