Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

API CHANGE Enable E_STRICT, but include DebugView, Log classes as these ... #313

Merged
merged 1 commit into from Apr 13, 2012

Conversation

Projects
None yet
2 participants
Owner

halkyon commented Apr 13, 2012

Re-enable E_STRICT after it was temporarily turned off.

Additionally, this fixes "class SS_Log not found" errors by explicitly requiring the required debugging classes in Core.php bootstrap code, because SS_ClassLoader::registerAutoloader() can't always guarantee that at the time the strict error was issued the Debug/Log classes were loaded yet.

This should be pulled after this issue is fixed: http://open.silverstripe.org/ticket/7135 which allieviates the problem of changing every getCMSFields method when upgrading because of the parameter differences.

API CHANGE Enable E_STRICT, but include DebugView, Log classes as the…
…se are not always guaranteed to be loaded by ClassLoader at the time a strict error is issued.

chillu added a commit that referenced this pull request Apr 13, 2012

Merge pull request #313 from halkyon/sapphire
---

Re-enable E_STRICT after it was temporarily turned off.

Additionally, this fixes "class SS_Log not found" errors by explicitly requiring the required debugging classes in Core.php bootstrap code, because `SS_ClassLoader::registerAutoloader()` cant always guarantee that at the time the strict error was issued the Debug/Log classes were loaded yet.

This should be pulled *after* this issue is fixed: http://open.silverstripe.org/ticket/7135 which allieviates the problem of changing every `getCMSFields` method when upgrading because of the parameter differences.

@chillu chillu merged commit 6db8f85 into silverstripe:master Apr 13, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment