Skip to content

BUGFIX: #7004 Fixes #350

Merged
merged 1 commit into from Apr 20, 2012

2 participants

@adrexia
adrexia commented Apr 19, 2012

Fixed the overflow bug in IE7, as per ticket #7004.

@adrexia adrexia BUGFIX: #7004 Fixes
Fixed the overflow bug in IE7, as per ticket #7004.
e2d6d59
@chillu
SilverStripe Ltd. member
chillu commented Apr 19, 2012

That's artificially limiting the tree width to 200px - what if we make the sidebar user-resizeable? There shouldn't be any width assumptions encoded in the tree. Can't we do this through consistent use of display: inline-block/inline and whitespace: nowrap? Maybe have a look on the jstree.com mailinglist to see if anybody had a similar problem with the tree lib in general?

@adrexia
adrexia commented Apr 20, 2012

I can't seem to get IE7 to render whitespace:no-wrap, and it doesn't think you can float objects that don't have widths. I've tried a few different combinations, but they all seem to rely on giving an object a width.

I guess you could do it with javascript by calculating the current width of the cms panel and applying that width to the list element. Seems like a lot of work just to fix an IE7 bug, but I can look into it.

@chillu
SilverStripe Ltd. member
chillu commented Apr 20, 2012

OK, I actually didn't notice the fix was just for IE7 in my initial comments. Its still not great, but an acceptable solution - Thanks Naomi :)

@chillu chillu merged commit ef8651d into silverstripe:master Apr 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.