BUGFIX: Add padding to settings panel #377

Merged
merged 1 commit into from Apr 27, 2012

Projects

None yet

2 participants

@adrexia

Added padding back into the settings panel.

@chillu chillu merged commit f5c26e7 into silverstripe:master Apr 27, 2012
@chillu chillu added a commit that referenced this pull request May 7, 2012
@chillu chillu MINOR Reverting padding changes from pull request #377, way too globa…
…l - solved through a .cms-panel-padded class in CMSSettingsController instead
82cf938
@chillu
SilverStripe Ltd. member

This change turned out to be way too global, it added padding to half a dozen other CMS views, for example the "add page" view. @adrexia If you're introducing changes on such a global level, please also check their effects on other areas. That being said, I should've picked that up as well. Solved through a .cms-panel-padded class in CMSSettingsController instead

@adrexia

Sorry, looks like I didn't check it widely/deeply enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment