Explain the module specific themes separation capability of Silverstripe #3945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
:mind_blown: is this true?! Are there even any tests for this behaviour? |
|
Ya - its been around since 2.3 / 2.4 I think this line is the best proof: Not sure if there are tests. |
dhensby
added a commit
that referenced
this pull request
Mar 3, 2015
DOCS Explain the module specific themes separation capability of Silverstripe
| 2. themes | ||
| 3. modules | ||
| 4. framework. | ||
| 2. module-specific themes (e.g. themes/simple_blog) |
There was a problem hiding this comment.
Is this definitely the right priority? I answered this a while back: http://stackoverflow.com/questions/24969798/blog-template-isnt-overridden - I'm not sure if I'm right but I'm guessing I would have tested at the time. I'm fairly certain that themes are higher priority then mysite.
There was a problem hiding this comment.
My understanding is that mysite trumps all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A problem I had recently highlighted the need for some missing docs on how the
theme_modulesetup is possible.#3944