New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Fix trac ticket 7081 #553

Merged
merged 1 commit into from Jun 20, 2012

Conversation

Projects
None yet
2 participants
@hafriedlander
Member

hafriedlander commented Jun 20, 2012

IE contentEditable carets and selection boxes show on top of any elements, interfering with HtmlEditorFields dialogs. This fixes that by storing the selection prior to opening the dialog, then unselecting everything. On dialog close the selection is restored

This was marked as critical for RC1 but didn't quite make it. Chance of regression is medium - shouldn't affect anything outside HtmlEditorField, but HtmlEditorField will need retesting in all browsers.

I'm assuming the dialog interface isn't a stable API, and so haven't marked this as APICHANGE. If users have created their own derivatives of .htmleditorfield-form then they will need to make similar changes.

Hamish Friedlander
BUGFIX: Fix trac ticket 7081
IE contentEditable carets and selection boxes show on top of any elements, interfering with HtmlEditorFields dialogs.
This fixes that by storing the selection prior to opening the dialog, then unselecting everything. On dialog close the
selection is restored
@sminnee

This comment has been minimized.

Show comment
Hide comment
@sminnee

sminnee Jun 20, 2012

Member

Given it fixes a critical bug I'm happy for this to go into RC2.

Member

sminnee commented Jun 20, 2012

Given it fixes a critical bug I'm happy for this to go into RC2.

sminnee added a commit that referenced this pull request Jun 20, 2012

@sminnee sminnee merged commit 8ca961c into silverstripe:3.0 Jun 20, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment