New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Add batch handler status messages (fixes #7427) #563

Merged
merged 1 commit into from Jun 22, 2012

Conversation

Projects
None yet
2 participants
@hafriedlander
Member

hafriedlander commented Jun 22, 2012

7427 was mostly fixed by Ingo's previous patch. But two batch actions, delete from draft site and delete from published site werent returning status messages.

Abstracted out the status preparation code that the batch actions that were returning status messages were using, and used that to add status messages to the problem two

(Paired with pull request from CMS)

Hamish Friedlander
BUGFIX: Add batch handler status messages (fixes #7427)
7427 was mostly fixed by Ingos previous patch. But two batch actions, delete from draft site and delete from published site werent returning
status messages. Abstracted out the status preperation code that the batch actions that were returning status messages were using, and
used that to add status messages to the problem two
@hafriedlander

This comment has been minimized.

Show comment
Hide comment
@hafriedlander
Member

hafriedlander commented Jun 22, 2012

CMS pull request is at silverstripe/silverstripe-cms#153

@sminnee

This comment has been minimized.

Show comment
Hide comment
@sminnee

sminnee Jun 22, 2012

This seems okay to get us over the line for RC2, but this would be a good place to use named substitutions, rather than relying on arcane argument orders.

sminnee commented on admin/code/CMSBatchAction.php in 0346923 Jun 22, 2012

This seems okay to get us over the line for RC2, but this would be a good place to use named substitutions, rather than relying on arcane argument orders.

This comment has been minimized.

Show comment
Hide comment
@hafriedlander

hafriedlander Jun 22, 2012

Yeah, definitely minimum viable change. Didn't want to start mucking with translation strings at this late stage if I could avoid it.

hafriedlander replied Jun 22, 2012

Yeah, definitely minimum viable change. Didn't want to start mucking with translation strings at this late stage if I could avoid it.

sminnee added a commit that referenced this pull request Jun 22, 2012

Merge pull request #563 from silverstripe-rebelalliance/trac/7427-add…
…-responses

BUGFIX: Add batch handler status messages (fixes #7427)

@sminnee sminnee merged commit bafda93 into silverstripe:3.0 Jun 22, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment