Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
BUG: exclude() clears previously selected filters() (Trac #7529) #564
This bug was caused by the fact that SQLQuery::whereAny() removed existing filters. In line with addWhere() and setWhere(), I split this into addWhereAny() and setWhereAny(). Strictly speaking, this drops the method SQLQuery::whereAny(), but it was really just an internal function for exclude, and so I think that's acceptable.
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
Seems good, and matches the set/add methods which I changed in SQLQuery a short while back.
I wonder if we should at least add whereAny() back as a deprecated method that just calls