New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: ViewableData::setFailover() didn't remove cached methods #5662

Merged

dhensby merged 2 commits into silverstripe:3 from kinglozzer:viewabledata-definemethods-pt2

Jun 11, 2016

Member

kinglozzer commented Jun 7, 2016 •

edited

See #5655:

Hopefully the unit test explains what’s going on here. Turns out @tractorcow was quite correct in his comment in #4870 (comment):

You might also need a mechanism and test to ensure you remove methods from the removed failover, since it looks like the new ones are being merged with the old.

kinglozzer and others added 2 commits

June 7, 2016 16:17


          FIX: ViewableData::setFailover() didn't remove cached methods

429ce55


          Refactor duplicate code in Object

0ad6438

dhensby merged commit 91aa818 into silverstripe:3

kinglozzer deleted the viewabledata-definemethods-pt2 branch

June 13, 2016 08:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment