ENHANCEMENT: add optional custom menu icon to CMS main menu #725

Closed
wants to merge 9 commits into
from

4 participants

@Martimiz

Add optional custom menu icons to the CMS main menu for every class extending LeftAndMain (ModelAdmin). Works by setting optional static $menu_icon = '/path/to/image' and providing custom styling for added icons. Works for the menu as well as for the icon in the right-side (GridField) pane header.

@Martimiz Martimiz ENHANCEMENT: add optional custom menu icon to CMS main menu
Add optional custom menu icons to the CMS main menu for every class
extending LeftAndMain (ModelAdmin). Works by setting optional static
$menu_icon = '/path/to/image' and providing custom styling for added
icons. Works for the menu as well as icon in the right-side (GridField)
pane header.
e347295
@travisbot

This pull request passes (merged e347295 into 4916b36).

@chillu
SilverStripe Ltd. member

Good change! Can you please write a "Howto: Customize the CMS Menu" for this as well? The feature will only be half as useful if its not documented :)

@Martimiz

Sure... Should I create a seperate pull request for the howto, or combine the two in a new pull request?

@chillu
SilverStripe Ltd. member
@sminnee
SilverStripe Ltd. member

You should be able to simply commit to this branch and it wi be added to this pull requestz

Martimiz added some commits Aug 19, 2012
@Martimiz Martimiz ENHANCEMENT: add optional custom menu icon to CMS main menu
Add optional custom menu icons to the CMS main menu for every class
extending LeftAndMain (ModelAdmin). Works by setting optional static
$menu_icon = '/path/to/image' and providing custom styling for added
icons. Works for the menu as well as icon in the right-side (GridField)
pane header.
d30ed41
@Martimiz Martimiz Merge branch '3.0-cms-menu-icon' of https://github.com/Martimiz/sapphire
 into 3.0-cms-menu-icon
df10fe4
@travisbot

This pull request passes (merged df10fe4 into 69182c2).

Martimiz added some commits Aug 22, 2012
@Martimiz Martimiz DOCS: added doc how to customize the cms menu
Added doc on how to customize the cms to en/howto,
068e42d
@Martimiz Martimiz Update docs/en/howto/index.md
UPDATE: Added 5 missing links to howto/index.md, including one for Howto customize the CMS menu.
c422343
@Martimiz Martimiz Update docs/en/howto/customize-cms-menu.md 0682184
@travisbot

This pull request passes (merged 068e42d into 69182c2).

@travisbot

This pull request passes (merged c422343 into 69182c2).

@travisbot

This pull request passes (merged 0682184 into 69182c2).

@Martimiz

I wrote a 'Howto customize the CMS menu' and added the link to howto/index.md. While doing that I also added the other missing links to that file.

I hope this is what you had in mind. Maybe, if this gets merged, ModelAdmin and its doc should be updated as well with the $menu_icon? Also please check the syntax and grammar of my doc, since I'm not a native :-)

(BTW: posted a small problem with my branch earlier, but that is now fixed, so I removed it)

@travisbot

This pull request passes (merged 2447b55 into ae9c2e7).

@Martimiz Martimiz Update docs/en/howto/customize-cms-menu.md
Updated the topic on Language files (translation). When changing the $menu_title, existing language files stay the same, and, even for default language, SS will display the old MENUTITLE entity from the language file, so the changes won't reflect in the CMS menu unless you change that too.
2961db6
@Martimiz

Hi, I've changed the topic on language files and translations in the howto, because there was something else going on then I originally thought. It should be correct now. Please let me know if this is what you had in mind.

@travisbot

This pull request passes (merged 2961db6 into ae9c2e7).

@chillu
SilverStripe Ltd. member

Collapsed into one changeset, and committed in 82500dd.
Thanks Martimiz!

A couple of points though:

@chillu chillu closed this Aug 29, 2012
@Martimiz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment