Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the DBCurrency fields decimal_point and thousands_separator conf… #8466

Closed
wants to merge 1 commit into from

Conversation

@TheBnl
Copy link

TheBnl commented Oct 9, 2018

…igurable

Some countries have the decimal point and thousands separator switched around like €1.000,00 instead of $1,000.00

SilverStripe\ORM\FieldType\DBCurrency:
  currency_symbol: ''
  decimal_point: ','
  thousands_separator: '.'
…igurable

Some countries have the decimal point and thousands separator switched around like €1.000,00 instead of $1,000.00
@robbieaverill

This comment has been minimized.

Copy link
Member

robbieaverill commented Oct 9, 2018

Thanks for contributing! We have an open issue to implement localisation for currencies: #8216

I think that because this change would introduce a new API, and we're planning to replace this with Intl localisation at some point, that it would be a bad idea to merge it now.

You can overload the classes in your own project using Injector in order to keep this functionality for your projects, in the meantime.

Thank you =)

@TheBnl

This comment has been minimized.

Copy link
Author

TheBnl commented Oct 9, 2018

Ah yes using the injector is my current workflow indeed. I'll watch the thread for further updates!

@TheBnl TheBnl deleted the TheBnl:patch-1 branch Oct 9, 2018
@robbieaverill

This comment has been minimized.

Copy link
Member

robbieaverill commented Oct 9, 2018

Great, thanks for your understanding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.