BUG: DataObject::__construct() now accepts stdClass for $record #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
simonwelsh
added a commit
that referenced
this pull request
Nov 3, 2012
…lass API: DataObject::__construct() now accepts stdClass for $record
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataObject::__construct() currently only accepts an array. This works fine the majority of the time, but a minor enhancement is to allow stdClass to be accepted as well.
The reason for this is that PDO results are often fetched as objects when doing database migrations, so being able to create new DataObjects directly from the results of a PDO statement fetch is very useful.
There should be no side-effects from this, as the additional acceptance is limited to stdClass, which is only produced in cases where an anonymous object is constructed, usually from a typecast to an object, but in certain other cases as well, such as PDOStatement::fetch(PDO::FETCH_OBJ).