BUG Fixing encoding issue with non-ASCII characters #953

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Owner

halkyon commented Nov 15, 2012

GridFieldAddExistingAutocompleter messes up non-ASCII characters
because GridField.js uses escape() to encode URI paramters.
This is known to be broken, and encodeURIComponent() is a better
alternative.

See http://stackoverflow.com/questions/75980/best-practice-escape-or-encodeuri-encodeuricomponent
for more information

Raised on this forum post: http://www.silverstripe.org/general-questions/show/21433#post318162

@halkyon halkyon BUG Fixing encoding issue with non-ASCII characters
GridFieldAddExistingAutocompleter messes up non-ASCII characters
because GridField.js uses escape() to encode URI paramters.
This is known to be broken, and encodeURIComponent() is a better
alternative.

See http://stackoverflow.com/questions/75980/best-practice-escape-or-encodeuri-encodeuricomponent
for more information
bdc525d
Owner

wilr commented Nov 15, 2012

Duplicate of #950...

Owner

chillu commented Nov 15, 2012

Haha, well sorry Sean, Will was 2h faster ;)

chillu closed this Nov 15, 2012

Owner

halkyon commented Nov 15, 2012

cough mine's better :P

Owner

halkyon commented Nov 15, 2012

By the way, my pull request was going to 3.0, whereas the one @willr merged was to master.

Should we merge this back? Seems like a good enough fix for the next 3.0.4 release...

Owner

chillu commented Nov 15, 2012

Yep, its an annoying issue for international users, and doesn't affect any APIs, let's merge back to 3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment