{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":257418763,"defaultBranch":"3","name":"silverstripe-search-service","ownerLogin":"silverstripe","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2020-04-20T22:29:44.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/379348?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1713322947.0","currentOid":""},"activityList":{"items":[{"before":"4509830c320e6de1a0b733c183ef9475c074947e","after":"afbe3848e4212f8f5f9250fc0f6bd392db375344","ref":"refs/heads/3","pushedAt":"2024-05-02T04:32:43.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"blueo","name":"Bernard Hamlin","path":"/blueo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/948122?s=80&v=4"},"commit":{"message":"Show in search check for files (#92)\n\n* Index or remove from index based on ShowInSearch value\r\n\r\n* Add Show in search and last indexed field to file details tab\r\n\r\n* Add tests and revert onAfterPublish code\r\n\r\n* Add DataObject search content controls\r\n\r\n* Generic SearchFormFactoryExtension and fixing tests\r\n\r\n* Add config and update tests\r\n\r\n* Default config and update doc\r\n\r\n* Update ShowInSearch if files is not set to index\r\n\r\n* Add tests for SearchFormFactoryExtension\r\n\r\n* Fix broken tests\r\n\r\n* Linting fixes\r\n\r\n* Show in search remove duplicated field for SiteTree main tab\r\n\r\n* Update settings for SiteTree objects","shortMessageHtmlLink":"Show in search check for files (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2245014988\" data-permission-text=\"Title is private\" data-url=\"https://github.com/silverstripe/silverstripe-search-service/issues/92\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/silverstripe/silverstripe-search-service/pull/92/hovercard\" href=\"https://github.com/silverstripe/silverstripe-search-service/pull/92\">#92</a>)"}},{"before":"e95d2345dc69d38c14731abf135d0a9405f108e5","after":null,"ref":"refs/heads/pulls/force-live-on-unserialize","pushedAt":"2024-04-17T03:00:52.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"blueo","name":"Bernard Hamlin","path":"/blueo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/948122?s=80&v=4"}},{"before":"0bede9cdaa27d4c77e8af622f4dcb9d6f4d7b1f3","after":"4509830c320e6de1a0b733c183ef9475c074947e","ref":"refs/heads/3","pushedAt":"2024-04-17T03:00:44.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"blueo","name":"Bernard Hamlin","path":"/blueo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/948122?s=80&v=4"},"commit":{"message":"Force live object when adding to the index (#91)\n\nThis corrects behaviour that potentially allows indexing of draft content. Queues are normally run via a \"dev task\" which is run in the DevelopmentAdmin context. This controller will set the reading mode to DRAFT. The upshot of this is that an Index job will unserialise a DataObject in DRAFT reading mode (saved as a Data Query param) and the subsequent `toArray` call could get draft content. This is often seen as a link indexed with `?stage=Stage` parameters.\r\n\r\nThe impact is likely limited because an IndexJob is usually queued by a publish action and run shortly afterwards. In these cases it is unlikely that draft changes are present - but is isn't impossible.\r\n\r\nI checked the ReIndexJob run and it doesn't appear to have this issue because it sets the reading mode in the setup method. I have instead added this to the unserialise function as it seemed a safer method to ensure the reading mode was as expected.","shortMessageHtmlLink":"Force live object when adding to the index (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2229990930\" data-permission-text=\"Title is private\" data-url=\"https://github.com/silverstripe/silverstripe-search-service/issues/91\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/silverstripe/silverstripe-search-service/pull/91/hovercard\" href=\"https://github.com/silverstripe/silverstripe-search-service/pull/91\">#91</a>)"}},{"before":"6588580e8cbcab16ee1faff3ef73cd9fdc1516b4","after":"e95d2345dc69d38c14731abf135d0a9405f108e5","ref":"refs/heads/pulls/force-live-on-unserialize","pushedAt":"2024-04-15T04:49:45.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"blueo","name":"Bernard Hamlin","path":"/blueo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/948122?s=80&v=4"},"commit":{"message":"Force live on adding to index","shortMessageHtmlLink":"Force live on adding to index"}},{"before":"43c744b47cca6df3f0342fe215c6c94092872d29","after":"6588580e8cbcab16ee1faff3ef73cd9fdc1516b4","ref":"refs/heads/pulls/force-live-on-unserialize","pushedAt":"2024-04-15T02:27:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"blueo","name":"Bernard Hamlin","path":"/blueo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/948122?s=80&v=4"},"commit":{"message":"Force live on adding to index","shortMessageHtmlLink":"Force live on adding to index"}},{"before":"6081ac9fc3fe579375878f2f86431fa45b9ae453","after":"0bede9cdaa27d4c77e8af622f4dcb9d6f4d7b1f3","ref":"refs/heads/3","pushedAt":"2024-04-12T01:27:44.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"blueo","name":"Bernard Hamlin","path":"/blueo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/948122?s=80&v=4"},"commit":{"message":"FIX Unpublising parent pages should include child pages (#89)\n\n* FIX Unpublising parent pages should include child pages\r\nfixes Issue [#88](https://github.com/silverstripe/silverstripe-search-service/issues/88) Uses `SiteTree::enforce_strict_hierarchy` config in getting the dependent documents for indexing child pages.\r\n\r\n* Bugfix `DataObjectDocument::getDependentDocuments` to get dependencies via `has_one` relationships\r\n---------\r\n\r\nCo-authored-by: Bernard Hamlin <948122+blueo@users.noreply.github.com>","shortMessageHtmlLink":"FIX Unpublising parent pages should include child pages (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1916994355\" data-permission-text=\"Title is private\" data-url=\"https://github.com/silverstripe/silverstripe-search-service/issues/89\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/silverstripe/silverstripe-search-service/pull/89/hovercard\" href=\"https://github.com/silverstripe/silverstripe-search-service/pull/89\">#89</a>)"}},{"before":"5e1579b337c2fde62532f487eb563b13afc49596","after":"43c744b47cca6df3f0342fe215c6c94092872d29","ref":"refs/heads/pulls/force-live-on-unserialize","pushedAt":"2024-04-07T22:46:42.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"blueo","name":"Bernard Hamlin","path":"/blueo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/948122?s=80&v=4"},"commit":{"message":"Force live object on unserialise\n\nThis corrects behaviour that potentially allows indexing of draft content. Queues are normally run via a \"dev task\" which is run in the DevelopmentAdmin context. This controller will set the reading mode to DRAFT. The upshot of this is that an Index job will unserialise a DataObject in DRAFT reading mode (saved as a Data Query param) and the subsequent `toArray` call could get draft content. This is often seen as a link indexed with `?stage=Stage` parameters.\n\nThe impact is likely limited because an IndexJob is usually queued by a publish action and run shortly afterwards. In these cases it is unlikely that draft changes are present - but is isn't impossible.\n\nI checked the ReIndexJob run and it doesn't appear to have this issue because it sets the reading mode in the setup method. I have instead added this to the unserialise function as it seemed a safer method to ensure the reading mode was as expected.","shortMessageHtmlLink":"Force live object on unserialise"}},{"before":null,"after":"5e1579b337c2fde62532f487eb563b13afc49596","ref":"refs/heads/pulls/force-live-on-unserialize","pushedAt":"2024-04-07T22:42:02.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"blueo","name":"Bernard Hamlin","path":"/blueo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/948122?s=80&v=4"},"commit":{"message":"Force live object on unserialise\n\nThis corrects behaviour that potentially allows indexing of draft content. Queues are normally run via a \"dev task\" which is run in the DevelopmentAdmin context. This controller will set the reading mode to DRAFT. The upshot of this is that an Index job will unserialise a DataObject in DRAFT reading mode (saved as a Data Query param) and the subsequent `toArray` call could get draft content. This is often seen as a link indexed with `?stage=Stage` parameters.\n\nThe impact is likely limited because an IndexJob is usually queued by a publish action and run shortly afterwards. In these cases it is unlikely that draft changes are present - but is isn't impossible.\n\nI checked the ReIndexJob run and it doesn't appear to have this issue because it sets the reading mode in the setup method. I have instead added this to the unserialise function as it seemed a safer method to ensure the reading mode was as expected.","shortMessageHtmlLink":"Force live object on unserialise"}},{"before":null,"after":"6081ac9fc3fe579375878f2f86431fa45b9ae453","ref":"refs/heads/3","pushedAt":"2023-06-23T01:22:16.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"GuySartorelli","name":"Guy Sartorelli","path":"/GuySartorelli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/36352093?s=80&v=4"},"commit":{"message":"Bugfix: Remove GridFieldFilterHeader from ModelAdmin GridField","shortMessageHtmlLink":"Bugfix: Remove GridFieldFilterHeader from ModelAdmin GridField"}},{"before":null,"after":"e91ed1b727e070b6d05fc5e0aa2320ed85d4e1da","ref":"refs/heads/2.1","pushedAt":"2023-05-10T01:37:11.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"GuySartorelli","name":"Guy Sartorelli","path":"/GuySartorelli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/36352093?s=80&v=4"},"commit":{"message":"Bugfix: Remove GridFieldFilterHeader from ModelAdmin GridField (#84)\n\n- Relates to changes made in Framework 4.13","shortMessageHtmlLink":"Bugfix: Remove GridFieldFilterHeader from ModelAdmin GridField (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1702955996\" data-permission-text=\"Title is private\" data-url=\"https://github.com/silverstripe/silverstripe-search-service/issues/84\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/silverstripe/silverstripe-search-service/pull/84/hovercard\" href=\"https://github.com/silverstripe/silverstripe-search-service/pull/84\">#84</a>)"}},{"before":"296878bc495243b2ca47ef7bd3bf36c6ea6a8c52","after":null,"ref":"refs/heads/bugfix/remove-gridfield-filter-header-v3","pushedAt":"2023-05-10T01:35:22.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"chrispenny","name":"Chris Penny","path":"/chrispenny","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/505788?s=80&v=4"}},{"before":"a6aa0b2342fe10f0b763a53cd817ee67213c6b93","after":"6081ac9fc3fe579375878f2f86431fa45b9ae453","ref":"refs/heads/master","pushedAt":"2023-05-10T01:35:19.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"chrispenny","name":"Chris Penny","path":"/chrispenny","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/505788?s=80&v=4"},"commit":{"message":"Bugfix: Remove GridFieldFilterHeader from ModelAdmin GridField","shortMessageHtmlLink":"Bugfix: Remove GridFieldFilterHeader from ModelAdmin GridField"}},{"before":null,"after":"296878bc495243b2ca47ef7bd3bf36c6ea6a8c52","ref":"refs/heads/bugfix/remove-gridfield-filter-header-v3","pushedAt":"2023-05-10T01:30:33.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"chrispenny","name":"Chris Penny","path":"/chrispenny","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/505788?s=80&v=4"},"commit":{"message":"Bugfix: Remove GridFieldFilterHeader from ModelAdmin GridField","shortMessageHtmlLink":"Bugfix: Remove GridFieldFilterHeader from ModelAdmin GridField"}},{"before":"c77b77a370b8ca8688ffc889c5eb9005dd942e21","after":null,"ref":"refs/heads/bugfix/remove-gridfield-filter-header","pushedAt":"2023-05-10T01:27:23.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"chrispenny","name":"Chris Penny","path":"/chrispenny","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/505788?s=80&v=4"}},{"before":"079a81f9cee226104e58e655a632b5b19a257799","after":"e91ed1b727e070b6d05fc5e0aa2320ed85d4e1da","ref":"refs/heads/2","pushedAt":"2023-05-10T01:27:19.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"chrispenny","name":"Chris Penny","path":"/chrispenny","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/505788?s=80&v=4"},"commit":{"message":"Bugfix: Remove GridFieldFilterHeader from ModelAdmin GridField (#84)\n\n- Relates to changes made in Framework 4.13","shortMessageHtmlLink":"Bugfix: Remove GridFieldFilterHeader from ModelAdmin GridField (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1702955996\" data-permission-text=\"Title is private\" data-url=\"https://github.com/silverstripe/silverstripe-search-service/issues/84\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/silverstripe/silverstripe-search-service/pull/84/hovercard\" href=\"https://github.com/silverstripe/silverstripe-search-service/pull/84\">#84</a>)"}},{"before":"14fec2ecdd5e27785f1f866d85806aa3d5663981","after":"c77b77a370b8ca8688ffc889c5eb9005dd942e21","ref":"refs/heads/bugfix/remove-gridfield-filter-header","pushedAt":"2023-05-10T01:23:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"chrispenny","name":"Chris Penny","path":"/chrispenny","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/505788?s=80&v=4"},"commit":{"message":"Linting","shortMessageHtmlLink":"Linting"}},{"before":"9e4b77dd2df451aa38864e7305ee23978e5fd55f","after":"14fec2ecdd5e27785f1f866d85806aa3d5663981","ref":"refs/heads/bugfix/remove-gridfield-filter-header","pushedAt":"2023-05-10T01:19:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"chrispenny","name":"Chris Penny","path":"/chrispenny","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/505788?s=80&v=4"},"commit":{"message":"Add new linting exclusions for PHPCS","shortMessageHtmlLink":"Add new linting exclusions for PHPCS"}},{"before":null,"after":"9e4b77dd2df451aa38864e7305ee23978e5fd55f","ref":"refs/heads/bugfix/remove-gridfield-filter-header","pushedAt":"2023-05-10T01:07:52.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"chrispenny","name":"Chris Penny","path":"/chrispenny","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/505788?s=80&v=4"},"commit":{"message":"Bugfix: Remove GridFieldFilterHeader from ModelAdmin GridField\n- Relates to changes made in Framework 4.13","shortMessageHtmlLink":"Bugfix: Remove GridFieldFilterHeader from ModelAdmin GridField"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEP2rnIgA","startCursor":null,"endCursor":null}},"title":"Activity · silverstripe/silverstripe-search-service"}