Fixes #239, cacheKeyComponent updates cache key when filtering is dis…

…abled
silverstripe · Apr 4, 2016 · 07bd3c5 · 07bd3c5
1 parent e84b612
commit 07bd3c5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/code/model/Translatable.php b/code/model/Translatable.php
@@ -1811,7 +1811,7 @@ function getTranslatedLangs() {
 	 * Return a piece of text to keep DataObject cache keys appropriately specific
 	 */
 	function cacheKeyComponent() {
-		return 'locale-'.self::get_current_locale();
+		return self::locale_filter_enabled() ? 'locale-'.self::get_current_locale() : 'locale-filter-disabled';
 	}
 
 	/**

diff --git a/tests/unit/TranslatableTest.php b/tests/unit/TranslatableTest.php
@@ -100,6 +100,15 @@ function testGetOneByLocale() {
 		);
 		$this->assertEquals($translated->ID, $found->ID);
 		Translatable::enable_locale_filter();
+
+		//test caching of get_one when filtering is disabled
+		Translatable::set_current_locale('de_DE'); //cache failed lookup
+		$notFound = DataObject::get_one('SiteTree', '"URLSegment" = \'home\'');
+		$this->assertFalse($notFound, 'Should not have found a home page for de_DE');
+		Translatable::disable_locale_filter();
+		$found = DataObject::get_one('SiteTree', '"URLSegment" = \'home\'');
+		$this->assertInstanceOf('DataObject', $found, 'Should have found a home page with locale filtering off');
+		Translatable::enable_locale_filter();
 	}
 
 	function testLocaleFilteringEnabledAndDisabled() {