Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Submission Join Table GET code issue (fix for 3.0.5) #96

Closed
jonshutt opened this Issue Mar 12, 2013 · 2 comments

Comments

Projects
None yet
2 participants

Hi,
Using SS3.0.5.

UserDefinedForm.php line 122:
had to move "" to encompass the whole line or else SS was putting the " in the wrong places

changed to "SubmittedForm.ParentID => $this->ID"

also

UserFormsGridFieldFilterHeader.php line 39

changed to "SubmittedForm.ParentID => $gridField->getList()->column()"

fixes issues in 3.0.5, but haven't tested in other versions

Owner

wilr commented Mar 13, 2013

Can you submit a pull request? I don't think I follow. You need to do SubmittedFormField as the join filter. Note that this works fine for me in 3.1, 3.0 seemed to have an issue with this.

Will do. The problem with the original was the SS was seemed to be inserting quotes around SubmittedForm.ParentID, where it should be SubmittedForm.ParentID, moving the "" quotes to encompass the whole line fixed it for me. I'll test on different installation of SS3, and submit

@wilr wilr closed this Mar 15, 2013

@jedateach jedateach added a commit to jedateach/silverstripe-userforms that referenced this issue Mar 18, 2013

@wilr @jedateach wilr + jedateach FIX: fix submissions grid field in 3.0 versions (#96, #100) e7e5660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment