Removed jquery-validate and re-added as git submodule #74

Closed
wants to merge 6 commits into
from

Projects

None yet

2 participants

@mschilder

/thirdparty/jquery-validate was not up-to-date. Have removed this folder and re-added it as a submodule.

@mschilder

Willr, the pull request needs one extra modification as there is no jquery.validate.min.js, only jquery.validate.js. All my requests have been added today's commits. Pls review and include :)

@wilr
Member
wilr commented Dec 6, 2012

Thanks. You should also update the readme to include the fact that you need to run git submodule update --init --recursive when you git clone the module (otherwise people will be missing the files)

Also your changes to nl_NL won't be merged as they'll be overridden when we next update from getlocalization. See http://doc.silverstripe.org/framework/en/trunk/misc/contributing/translation for documentation regarding translations.

@mschilder

Have made suggested changes. I'm quite new to this. How can I help to improve Dutch lang files?

@mschilder

Willr, happy NY. Could/should you commit my pull request?

@wilr
Member
wilr commented Jan 29, 2013

Thanks mschilder! Like the new placeholder label work, very nice. Sorry for the delay, just got back a couple weeks ago from a month off so trucking through the backlog.

Little bit worried about the git submodule stuff as it'll catch people out I'm positive but will keep an eye on the forum to see if anyone runs into it. Not much more we could do, I've made it run automatically for composer based installations in 09971a5.

@wilr wilr closed this Jan 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment