Revamp options menu / add option for file click action #63

Closed
ZombieHippie opened this Issue Mar 2, 2014 · 18 comments

Projects

None yet

2 participants

@ZombieHippie
Collaborator

I think that it would be easier to edit a document if you click it rather than using the entry-menu and opening it.

If we looked at droppy as a tool that was more catered to server administrators, this would be the desired functionality, but if it was a consumer they may want to download when they click a file.

Maybe the behaviour of clicking a file could be another configuration parameter.

@ZombieHippie
Collaborator

Something that I've been thinking a lot about is the distance between .data-row .entry-menu and .data-row .entry-link which makes it hard to tell which file you are going to pull the entry menu up for.

image

If there are two views on desktop, this would not be as strange since it could be horizontally split.

@silverwind
Owner

I suppose that would be a nice feature to have, I'd make it a client-side option, reachable through our current "Manage" button, which I would rename to "Options", and then put the user management (which is somewhat broken right now) into another sub-menu inside our options menu.

@ZombieHippie
Collaborator
@silverwind
Owner

Regarding the line width, I'm not sure either, we could

  • Increase the font size even more
  • Put a maximum width on a single-view content container. Not sure what do do with the space left and right though.
@silverwind silverwind added this to the 1.0 milestone Mar 4, 2014
@silverwind silverwind self-assigned this Mar 10, 2014
@silverwind
Owner

I think I'll check this out next, the options menu is a mess code-wise, that needs to be cleaned up badly :P

@ZombieHippie
Collaborator
@ZombieHippie
Collaborator
@silverwind
Owner

You mean an priviledged user should be able to set options for everyone? Or do you mean adding the editor options on it?

My initial thought for priviledged users was that they had the ability to add other users (so there's no need to go to the server console to add users).

@ZombieHippie
Collaborator
@silverwind
Owner

Privileged user can set other people's priviledges, like being readonly users or admin users.

Ah, I see. I somehow misread your previous comment.

A preference/settings modal would also be able to combine with the manage modal for users that have permissions.

Yep, that's my intention.

I think we should have a preferences modal that centralizes all user preferences in one menu.

I'll probably move the three editor options into the main option menu. For WordWrap specifically, I'd still keep a toggle button around. Maybe even keep the color scheme selector.

@ZombieHippie
Collaborator

I'll probably move the three editor options into the main option menu. For WordWrap specifically, I'd still keep a toggle button around. Maybe even keep the color scheme selector.

Exactly what I was thinking. I think that tab-spacing options should be available on every document view though. But more advanced options only shown in the Preferences modal might be font-size, and preferred dark and light cm themes.

@silverwind
Owner

Agreed, color scheme should be in the options.

@silverwind silverwind added a commit that referenced this issue Mar 10, 2014
@silverwind Merge branch 'master' of https://github.com/silverwind/droppy
* 'master' of https://github.com/silverwind/droppy:
  Remove duplicate code
  Set options for all CM instances #63
befb125
@silverwind
Owner

Some more progress on styling, the right half is for use management.

opts

@ZombieHippie
Collaborator

Nice, I assume that it will be half-wide for non-admin users

@silverwind
Owner

Yeah, and it will collapse to a single row on smaller screens.

@silverwind silverwind added a commit that referenced this issue Mar 12, 2014
@silverwind More work on options, #63 4916595
@silverwind
Owner

I feel a bit sorry for adding these HMTL creation functions now while you're doing templates. Hopefully they won't be too hard to convert.

For the options menu itself, I just need to add user creation/deletion and it's done.

@ZombieHippie
Collaborator

Don't worry about it! Templating isn't too hard. I'll start templating it after this is closed.

@silverwind
Owner

Alright, It's done. You can template it now if you like. I'll push another release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment