Skip to content

Resizing the Browser Window Should Not Change the On/Off State of Grid #5

Closed
AlexisWalravens opened this Issue May 22, 2012 · 9 comments

2 participants

@AlexisWalravens

Hello,

Just to tell you that the grid shows up automatically when the window is resized.

That would be great if you can fixed that.

Thanks in advance.

@simanek
Owner
simanek commented May 23, 2012

Thanks for pointing out this shortcoming.

@simanek simanek was assigned May 23, 2012
@simanek
Owner
@simanek simanek added a commit that referenced this issue May 25, 2012
@simanek should fix issue #5 f1c2042
@simanek simanek added a commit that referenced this issue May 25, 2012
@simanek This should fix issue #5 aa56f72
@simanek simanek added a commit that referenced this issue May 25, 2012
@simanek again, this should fix issue #5 d431ca4
@simanek
Owner
simanek commented May 25, 2012

Had to dig myself out of a bad merge, so the 4 commits above are actually just 2 commits done twice. Please download the latest versions of

  • example_responsive.html
  • hugrid.js

I have added a new variable "gridstate" that records the current state of the grid (on or off). This makes it possible to preserve that state as the browser window is resized.

@simanek
Owner
@simanek
Owner
simanek commented May 25, 2012

So the email reply I attempted to send ended up becoming a comment on this issue... Is it obvious that I'm new to Github? :D

@AlexisWalravens

Sorry for the time I took to reply.

It looks like it's fixed. :D

So, I just have to replace hugrid.js on my site to fix it ?

Thanks a lot for fixing that so quickly !

@simanek
Owner
simanek commented May 25, 2012

@Pix3lmate Yes, replace hugrid.js and review the example_responsive.html javascript in the head element. There's a new function referred to within the window.resize function.

@simanek
Owner
simanek commented Jun 2, 2012

This problem is successfully fixed!

@simanek simanek closed this Jun 2, 2012
@AlexisWalravens

Thanks again ! I'm gonna use it in my new portfolio i'm working on ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.