New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizing the Browser Window Should Not Change the On/Off State of Grid #5

Closed
AlexisWalravens opened this Issue May 22, 2012 · 9 comments

Comments

Projects
None yet
2 participants
@AlexisWalravens
Copy link

AlexisWalravens commented May 22, 2012

Hello,

Just to tell you that the grid shows up automatically when the window is resized.

That would be great if you can fixed that.

Thanks in advance.

@simanek

This comment has been minimized.

Copy link
Owner

simanek commented May 23, 2012

Thanks for pointing out this shortcoming.

@ghost ghost assigned simanek May 23, 2012

@simanek

This comment has been minimized.

Copy link
Owner

simanek commented May 23, 2012

Thanks for submitting a issue/bug! You and another individual submitted
the identical problem at almost the exact same time! I'll try to take a
look this weekend while also getting reacquainted with Git/Github, which
is long overdue.

Jason Simanek

On 05/22/2012 09:25 AM, Pix3lmate wrote:

Hello,

Just to tell you that the grid shows up automatically when the window is resized.

That would be great if you can fixed that.

Thanks in advance.


Reply to this email directly or view it on GitHub:
#5

simanek added a commit that referenced this issue May 25, 2012

simanek added a commit that referenced this issue May 25, 2012

simanek added a commit that referenced this issue May 25, 2012

simanek added a commit that referenced this issue May 25, 2012

@simanek

This comment has been minimized.

Copy link
Owner

simanek commented May 25, 2012

Had to dig myself out of a bad merge, so the 4 commits above are actually just 2 commits done twice. Please download the latest versions of

  • example_responsive.html
  • hugrid.js

I have added a new variable "gridstate" that records the current state of the grid (on or off). This makes it possible to preserve that state as the browser window is resized.

@simanek

This comment has been minimized.

Copy link
Owner

simanek commented May 25, 2012

Hello,

I have just submitted a fix. Please take a look here:

#5

and (in case you aren't familiar with Github – I'm still learning
myself) you can download the new version here:

https://github.com/simanek/Heads-Up-Grid/downloads

The bug/issue page describes which files were changed. Let me know via
email or comment on the Github issue directly if this update fixes the
problem.

Jason Simanek

On Wed 23 May 2012 07:43:13 AM CDT, Jason Simanek wrote:

Thanks for submitting a issue/bug! You and another individual
submitted the identical problem at almost the exact same time! I'll
try to take a look this weekend while also getting reacquainted with
Git/Github, which is long overdue.

Jason Simanek

On 05/22/2012 09:25 AM, Pix3lmate wrote:

Hello,

Just to tell you that the grid shows up automatically when the window
is resized.

That would be great if you can fixed that.

Thanks in advance.


Reply to this email directly or view it on GitHub:
#5

@simanek

This comment has been minimized.

Copy link
Owner

simanek commented May 25, 2012

So the email reply I attempted to send ended up becoming a comment on this issue... Is it obvious that I'm new to Github? :D

@AlexisWalravens

This comment has been minimized.

Copy link
Author

AlexisWalravens commented May 25, 2012

Sorry for the time I took to reply.

It looks like it's fixed. :D

So, I just have to replace hugrid.js on my site to fix it ?

Thanks a lot for fixing that so quickly !

@simanek

This comment has been minimized.

Copy link
Owner

simanek commented May 25, 2012

@Pix3lmate Yes, replace hugrid.js and review the example_responsive.html javascript in the head element. There's a new function referred to within the window.resize function.

@simanek

This comment has been minimized.

Copy link
Owner

simanek commented Jun 2, 2012

This problem is successfully fixed!

@simanek simanek closed this Jun 2, 2012

@AlexisWalravens

This comment has been minimized.

Copy link
Author

AlexisWalravens commented Jun 3, 2012

Thanks again ! I'm gonna use it in my new portfolio i'm working on ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment