Skip to content

simple javascript specific code fixes #2

Merged
merged 2 commits into from Mar 10, 2012

2 participants

@lucasrenan

it's just simple js specific code fixes. I will do a complete refactor to solve the global variables problem :)

@lucasrenan

@simanek,

any problem with the code?

@simanek
Owner

Since I'm trying to learn here, could you explain what was wrong with the original indentation? Is this the old tabs vs. spaces thing?

these fixes are based in jslint:

"JSLint is a static code analysis tool used in software development for checking if JavaScript source code complies with coding rules. It was developed by Douglas Crockford."

@simanek simanek merged commit 40b95a5 into simanek:master Mar 10, 2012
@simanek
Owner
simanek commented Mar 10, 2012

Sorry for the long delay. I have two things working against me: Not fluent with GIT. I'm pretty busy.

I went ahead and accepted your commit. Now I just need to figure out how to pull the new code down so I can test it. :D

@lucasrenan

ok jason, thanks for accepted it :)
so, you can pull the code running git pull origin master from command line to your local repo.
now I will work to solve the global variables problem.

@simanek
Owner
simanek commented Mar 10, 2012

Thanks for the help! (GIT and Heads-Up Grid)

I'm running Ubuntu Linux and have just discovered RabbitVCS which integrates GIT and SVN with the OS's file manager. Works pretty slick if you know which command is the one you need. I've finally accepted that my infrequent use of GIT and SVN makes learning the command line stuff pretty difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.