Skip to content

Add overflow values to the tests #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mr-c opened this issue Dec 30, 2020 · 2 comments
Open

Add overflow values to the tests #688

mr-c opened this issue Dec 30, 2020 · 2 comments
Labels
good first issue This is perfect if you're new to the project and looking to help. help wanted We lack either the expertise or time for this. Basically, "patches welcome".

Comments

@mr-c
Copy link
Collaborator

mr-c commented Dec 30, 2020 •
edited
Loading

Examples from #685

SIMDE_FLOAT32_C(-2147483650.0)
SIMDE_FLOAT32_C( 2147483649.0)

SIMDE_FLOAT64_C(-2147483650.0)
SIMDE_FLOAT64_C( 2147483649.0)

The procedure is:

  1. Find tests that use SIMDE_FLOAT32_C or SIMDE_FLOAT64_C in their test_vec
  2. Copy-n-paste an entry in the test_vec, modifying the inputs using the overflow values above. Don't worry about changing the expected result (r) yet.
  3. Run the tests on a processor that supports the native intrinsic. Copy the correct output values from the error logs.
  4. Send a PR
  5. Repeat!
@mr-c mr-c mentioned this issue Dec 30, 2020
Closed
@mr-c mr-c added good first issue This is perfect if you're new to the project and looking to help. help wanted We lack either the expertise or time for this. Basically, "patches welcome". labels Dec 30, 2020
@qvd808
Copy link
Contributor

qvd808 commented Oct 2, 2024

Hi @mr-c , Do you still need help with this issue?

@mr-c
Copy link
Collaborator Author

mr-c commented Oct 2, 2024

Hi @mr-c , Do you still need help with this issue?

Yes, please!

@qvd808 qvd808 mentioned this issue Oct 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue This is perfect if you're new to the project and looking to help. help wanted We lack either the expertise or time for this. Basically, "patches welcome".
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mr-c @qvd808