Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beef #113

Merged
merged 6 commits into from Mar 21, 2020
Merged

Beef #113

merged 6 commits into from Mar 21, 2020

Conversation

Licenser
Copy link
Member

experiment with beef

closes #112

@codecov
Copy link

codecov bot commented Mar 20, 2020

Codecov Report

Merging #113 into master will decrease coverage by 0.25%.
The diff coverage is 48.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
- Coverage   87.15%   86.90%   -0.26%     
==========================================
  Files          34       34              
  Lines        4780     4795      +15     
==========================================
+ Hits         4166     4167       +1     
- Misses        614      628      +14     
Flag Coverage Δ
#avx2 81.26% <48.48%> (-0.22%) ⬇️
#avx2KnownKey 80.71% <48.48%> (-0.20%) ⬇️
#sse 82.01% <48.48%> (-0.26%) ⬇️
#sseKnownKey 81.44% <48.48%> (-0.26%) ⬇️
Impacted Files Coverage Δ
src/lib.rs 96.58% <ø> (ø)
src/serde/value/borrowed/de.rs 65.33% <0.00%> (-2.28%) ⬇️
src/serde/value/borrowed/se.rs 0.00% <0.00%> (ø)
src/value/owned/from.rs 88.52% <0.00%> (-3.01%) ⬇️
src/value/borrowed/from.rs 88.13% <16.66%> (-6.41%) ⬇️
src/serde/value/owned/de.rs 51.67% <25.00%> (-1.80%) ⬇️
src/known_key.rs 97.84% <100.00%> (ø)
src/value/borrowed.rs 99.44% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 361a914...91d045d. Read the comment docs.

@Licenser
Copy link
Member Author

Licenser commented Mar 20, 2020

before

======= simd_json ======== parse|stringify ===== parse|stringify ====
data/canada.json         500 MB/s   340 MB/s   670 MB/s   300 MB/s
data/citm_catalog.json  1020 MB/s   340 MB/s  1470 MB/s   450 MB/s
data/twitter.json        900 MB/s   540 MB/s  1050 MB/s   610 MB/s
data/log.json           1080 MB/s   720 MB/s  1080 MB/s   720 MB/s

===== simd_json_tape ===== parse|stringify ===== parse|stringify ====
data/canada.json         740 MB/s                    
data/citm_catalog.json  1720 MB/s                    
data/twitter.json       1590 MB/s                    
data/log.json           2170 MB/s                    

After

======= simd_json ======== parse|stringify ===== parse|stringify ====
data/canada.json         540 MB/s   350 MB/s   680 MB/s   310 MB/s
data/citm_catalog.json  1100 MB/s   330 MB/s  1490 MB/s   430 MB/s
data/twitter.json        950 MB/s   520 MB/s  1060 MB/s   590 MB/s
data/log.json           1080 MB/s   720 MB/s  1080 MB/s   720 MB/s

===== simd_json_tape ===== parse|stringify ===== parse|stringify ====
data/canada.json         760 MB/s                    
data/citm_catalog.json  1840 MB/s                    
data/twitter.json       1650 MB/s                    
data/log.json           2170 MB/s                    

@Licenser
Copy link
Member Author

This is behind a feature flag as it makes the interface harder to use and 'forces' an additional non-standard crate. But it looks like it's worth it in some cases especially for tape parsing.

@Licenser Licenser marked this pull request as ready for review March 21, 2020 12:19
@Licenser
Copy link
Member Author

the 0.26% decrease in coverage is probably based on property-based variation, so in acceptable limits

darach
darach approved these changes Mar 21, 2020
Copy link
Contributor

@darach darach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Licenser Licenser merged commit 932f36b into master Mar 21, 2020
@Licenser Licenser deleted the beef branch June 17, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate beef as a Cow replacement
2 participants