Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more clippy errros and add docs #52

Merged
merged 9 commits into from Oct 3, 2019
Merged

Fix more clippy errros and add docs #52

merged 9 commits into from Oct 3, 2019

Conversation

@Licenser
Copy link
Member

Licenser commented Oct 3, 2019

No description provided.

@sunnygleason

This comment has been minimized.

Copy link
Member

sunnygleason commented Oct 3, 2019

wow, this is a lot of work & documentation, very nice!

@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 3, 2019

Codecov Report

Merging #52 into master will decrease coverage by 0.05%.
The diff coverage is 70.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
- Coverage   64.14%   64.09%   -0.06%     
==========================================
  Files          37       37              
  Lines        3924     3949      +25     
==========================================
+ Hits         2517     2531      +14     
- Misses       1407     1418      +11
Impacted Files Coverage Δ
src/macros.rs 100% <ø> (ø) ⬆️
src/avx2/deser.rs 77.41% <ø> (ø) ⬆️
src/stringparse.rs 90% <ø> (ø) ⬆️
src/serde/value/borrowed/de.rs 0% <0%> (ø) ⬆️
src/value/borrowed/serialize.rs 25.71% <0%> (ø) ⬆️
src/serde/value/owned/de.rs 1.73% <0%> (ø) ⬆️
src/value.rs 55.38% <0%> (-3.64%) ⬇️
src/value/owned/serialize.rs 26.76% <0%> (ø) ⬆️
src/sse42/utf8check.rs 100% <100%> (ø) ⬆️
src/serde.rs 69.59% <100%> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a8f144...c610428. Read the comment docs.

@Licenser Licenser force-pushed the docs-and-clippy branch from 0d55564 to dac6748 Oct 3, 2019
Licenser added 6 commits Oct 3, 2019
@Licenser Licenser marked this pull request as ready for review Oct 3, 2019
@Licenser Licenser requested a review from sunnygleason Oct 3, 2019
Copy link
Member

sunnygleason left a comment

LGTM! if the tests are happy I'm happy :)

@sunnygleason sunnygleason merged commit b4b9b85 into master Oct 3, 2019
21 checks passed
21 checks passed
clippy_check (-C target-cpu=native)
Details
build (stable, ubuntu-latest, -C target-cpu=native)
Details
clippy_check (-C target-cpu=native -C target-feature=-avx2)
Details
build (stable, ubuntu-latest, -C target-cpu=native -C target-feature=-avx2)
Details
build (stable, windows-latest, -C target-cpu=native)
Details
build (stable, windows-latest, -C target-cpu=native -C target-feature=-avx2)
Details
build (stable, macOS-latest, -C target-cpu=native)
Details
build (stable, macOS-latest, -C target-cpu=native -C target-feature=-avx2)
Details
build (nightly, ubuntu-latest, -C target-cpu=native)
Details
build (nightly, ubuntu-latest, -C target-cpu=native -C target-feature=-avx2)
Details
build (nightly, windows-latest, -C target-cpu=native)
Details
build (nightly, windows-latest, -C target-cpu=native -C target-feature=-avx2)
Details
build (nightly, macOS-latest, -C target-cpu=native)
Details
build (nightly, macOS-latest, -C target-cpu=native -C target-feature=-avx2)
Details
tarpaulin (-C target-cpu=native)
Details
tarpaulin (-C target-cpu=native -C target-feature=-avx2)
Details
clippy clippy
Details
codecov/patch 70.47% of diff hit (target 64.14%)
Details
codecov/project Absolute coverage decreased by -0.05% but relative coverage increased by +6.33% compared to 0a8f144
Details
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details
@sunnygleason sunnygleason deleted the docs-and-clippy branch Oct 3, 2019
@Licenser

This comment has been minimized.

Copy link
Member Author

Licenser commented Oct 3, 2019

tagged as v0.1.21 and published :

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.