Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Jul 2, 2012
  1. @fabpot

    merged branch fabpot/locale-listener (PR #4692)

    fabpot authored
    Commits
    -------
    
    88caf3a [HttpKernel] removed the storage of the current locale in the session
    
    Discussion
    ----------
    
    [HttpKernel] removed the storage of the current locale in the session
    
    Before this commit, the current locale was stored in the session (if one
    was already started). That way, for the next requests, even if the
    request locale attribute was not set, the locale was "restored".
    
    But this is a really bad practice as it means that the same URL can have
    a different content depending on the previous requests. It would have
    been better if the Vary header was set but the locale can be different
    from the value coming from the Accept-Language anyway.
    
    This is a BC break but fortunately, you can restore the 2.0 behavior by
    creating a simple event listener that contains the logic removed by this
    commit.
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-07-01T06:56:48Z
    
    This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1748659) (merged 009e30f0 into 2e356c1).
    
    ---------------------------------------------------------------------------
    
    by schmittjoh at 2012-07-01T08:15:46Z
    
    How about using a cookie instead? It would remove the BC break, and also be possible to use a vary header?
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-07-01T09:13:44Z
    
    The goal is to make Symfony as stateless as possible; introducing a cookie would defeat this goal.
    
    ---------------------------------------------------------------------------
    
    by drak at 2012-07-01T09:19:37Z
    
    @fabpot - thank you for bringing this to attention. I was meaning to do it a long time ago. The requested language is entirely a per request issue and must always be so. URLs must only ever return one content, and not multiple (e.g. different languages). The correct way to behave is to detect the language based on URL and failing that where a language is not requested, to look at the preferred language from the browser request and if available it can be redirected to that resource (e.g. /fr). This is what we do in Zikula. We have a further session based setting for "preferred language" which if set will override the browser default.
    
    In summary:
    
    1. If the language is specified in the GET request, return that language always. E.g. domain.com/fr/foo should return a French version of foo
    
    2. If no language is specified in the GET request: first check the session for a preferred language, otherwise check the browser string for the preferred language and then if necessary, redirect to that resource. We have a setting which additionally say "always have language in URL, and don't put language code in URL for default language"
    
    This means what in Zikula we only ever have one URL per language version of a page, but it still allows for users to set their preferred language which is taken in to account mainly when they visit the homepage (but in fact any page without a specific language in the request).
    
    ---------------------------------------------------------------------------
    
    by drak at 2012-07-01T09:38:06Z
    
    +1 on this PR. Basically the request locale should be in the Request object and calculated according to the applications preferences.
    
    ---------------------------------------------------------------------------
    
    by schmittjoh at 2012-07-01T12:38:25Z
    
    I agree that content must be detected based on the request, but I strongly disagree with relying entirely on the URL.
    
    @fabpot, if you think about it using a cookie would still be stateless. There would be no state whatsoever, the detection would be entirely based on the request. Whether the language information is transmitted in the URL or as part of request headers is for the developer to decide eventually, at least IMO. My suggestion would just provide a default which is more BC.
    
    ---------------------------------------------------------------------------
    
    by drak at 2012-07-01T20:08:50Z
    
    @schmittjoh it's not entirely from the URL, there are browser preferences and also user defaults ca nalso available but the latter is slightly higher level. IMO it's not really Symfony's job here, it's application level specific. We have a pretty good working example of that in Zikula. Anyone can easily implement your own requirements with a listener.
    
    What is absolutely clear however is it is wrong for one URL to deliver more than one version of any content.
    
    ---------------------------------------------------------------------------
    
    by schmittjoh at 2012-07-01T21:16:52Z
    
    I'm 100% for this change. My suggestion would just be more BC while still keeping Symfony2 stateless. Of course, it can be easily implemented in userland if we do not care about BC here.
    
    Regarding different URLs per content, I do not think that this is our decision to make. Generally, developers should be able to make whatever content negotation they see fit. Whether they rely solely on the URL, or also take other request headers into account should not be limited by Symfony2.
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-07-02T10:37:26Z
    
    I've added a paragraph in the UPGRADE file with a listener example that can be used to keep BC.
  2. @fabpot

    [HttpKernel] removed the storage of the current locale in the session

    fabpot authored
    Before this commit, the current locale was stored in the session (if one
    was already started). That way, for the next requests, even if the
    request locale attribute was not set, the locale was "restored".
    
    But this is a really bad practice as it means that the same URL can have
    a different content depending on the previous requests. It would have
    been better if the Vary header was set but the locale can be different
    from the value coming from the Accept-Language anyway.
    
    This is a BC break but fortunately, you can restore the 2.0 behavior by
    creating a simple event listener that contains the logic removed by this
    commit.
  3. @fabpot
  4. @fabpot

    merged branch wodor/profiler_rely_on_profile_3372 (PR #3373)

    fabpot authored
    Commits
    -------
    
    1472283 fixed CS
    bc73487 renamed template to TemplateManager , moved profiler to the deps of manager
    5fd6ed6 properties protected
    abd0eb7 generating template names moved out from controller  to another class
    6138e80 [Profiler] relying on config of displayed profile  instead of current config.
    
    Discussion
    ----------
    
    [2.2][Profiler] relying on config of displayed profile  instead of current config
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: code of ProfilerController is not covered by any test
    Fixes the following tickets: #3372
    Todo: ~
    
    This fixes the exception which is raised when viewed profile has other  data collectors than in config of currently run profiler.
    explained here
    symfony#3372
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-02-16T06:11:00Z
    
    This should probably be done on the 2.0 branch. Also, I think we need to check if the panel is actually available in the current profiler (if not, we won't be able to display it anyway). So, both checks are important.
    
    ---------------------------------------------------------------------------
    
    by wodor at 2012-02-18T10:15:40Z
    
    defects mentioned by Stof are fixed
  5. @fabpot

    merged branch SamsonIT/fix_dutch_translations (PR #4702)

    fabpot authored
    Commits
    -------
    
    6e168cd fixed dutch translations
    
    Discussion
    ----------
    
    fixed dutch translations
    
    mostly reverts a859f7
    
    e-mailadres: http://www.onzetaal.nl/taaladvies/advies/e-mailadres-emailadres
    "waarde" is not a neutral word, so it cannot be referred to as "het"
    "verwachte" here is an adjective, not a verb - http://www.leestrainer.nl/Leerlijn%20werkwoorden/als%20bijvnm%20schrijven.htm
  6. @Burgov

    fixed dutch translations

    Burgov authored
    mostly reverts a859f7
    
    e-mailadres: http://www.onzetaal.nl/taaladvies/advies/e-mailadres-emailadres
    "waarde" is not a neutral word, so it cannot be referred to as "het"
    "verwachte" here is an adjective, not a verb - http://www.leestrainer.nl/Leerlijn%20werkwoorden/als%20bijvnm%20schrijven.htm
  7. @fabpot

    merged branch nomack84/wdt_documentation_link_color_fix (PR #4260)

    fabpot authored
    Commits
    -------
    
    b804b94 Fixed style for the abbr tag
    147cab7 [WDT] Fix the color of Documentation link to keep concistence.
    
    Discussion
    ----------
    
    [WDT] Fix the color of Documentation link to keep concistence.
    
    This pull request is to make the Documentation link black as the other links of the WDT
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-11T13:33:24Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1304777) (merged 5a87a098 into 554e073).
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-05-11T16:36:39Z
    
    should be done via selector in the css file that is used for the WDT (also refactor the profiler token link like this)
    
    ---------------------------------------------------------------------------
    
    by nomack84 at 2012-05-11T17:46:15Z
    
    Done.
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-11T17:48:24Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1307502) (merged eee437c9 into 554e073).
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-11T18:27:55Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1307838) (merged 3604f131 into dd0da03).
    
    ---------------------------------------------------------------------------
    
    by mvrhov at 2012-05-11T18:40:05Z
    
    While you are at it, the controller text color is also wrong.
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-11T18:43:00Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1308018) (merged 147cab7 into dd0da03).
    
    ---------------------------------------------------------------------------
    
    by nomack84 at 2012-05-11T18:49:47Z
    
    @mvrhov I don't see the difference.
    
    ---------------------------------------------------------------------------
    
    by mvrhov at 2012-05-11T19:45:45Z
    
    Set the color for abbr tag on your website to red or something like that. By default abbr color is set to black. My website has is set to #55555 so the controller name its barely visible.
    
    ---------------------------------------------------------------------------
    
    by nomack84 at 2012-05-14T12:42:30Z
    
    @mvrhov Done!
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-14T12:43:48Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1326494) (merged b804b94 into dd0da03).
    
    ---------------------------------------------------------------------------
    
    by nomack84 at 2012-05-15T13:09:59Z
    
    Hi @fabpot,
    Can you merge this? The only thing it does is add a missed style to the Documentation link and also to the abbr tag, as suggested by @mvrhov.
    Greetings!
  8. @fabpot

    merged branch hvt/patch-1 (PR #4700)

    fabpot authored
    Commits
    -------
    
    a859f72 Better Dutch translation of some validator messages
    
    Discussion
    ----------
    
    [Validator] Better Dutch translation of some validator messages
  9. @hvt
  10. @fabpot

    merged branch vicb/finder/regex (PR #4699)

    fabpot authored
    Commits
    -------
    
    4d09fe6 [Finder] '*' and '?' are considered are glob pattern rather than delimiters (fix #4664)
    
    Discussion
    ----------
    
    [Finder] '*' and '?' are considered are glob pattern rather than delimit...
    
    ...ers (fix #4664)
  11. @vicb
Commits on Jul 1, 2012
  1. @fabpot

    [HttpKernel] fixed a test

    fabpot authored
  2. @fabpot

    fixed previous merge

    fabpot authored
  3. @fabpot

    merged branch dlsniper/session-start-fix (PR #4541)

    fabpot authored
    Commits
    -------
    
    f72ba0a Fixed detection of an active session
    
    Discussion
    ----------
    
    [WIP][HttpFoundation][Session] Fixed detection of an active session
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: not sure
    Symfony2 tests pass: no
    Fixes the following tickets: #4529
    Todo: Fix failing tests
    License of the code: MIT
    Documentation PR: ~
    
    This fixes the problem when the session variable inside $request now has always data in it as it's now more powerful but this introduces the problem that the old way of detecting if a session is started or not doesn't work anymore.
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-09T21:53:17Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1578839) (merged 9ae13e12 into 6266b72).
    
    ---------------------------------------------------------------------------
    
    by drak at 2012-06-10T01:57:59Z
    
    Sessions should be started implicitly. The SF auto_start config parameter controls the session listener to start the session.
    
    ---------------------------------------------------------------------------
    
    by dlsniper at 2012-06-11T06:46:02Z
    
    So this patch is correct then and I should continue the work on it?
    
    ---------------------------------------------------------------------------
    
    by drak at 2012-06-11T07:51:39Z
    
    @dlsniper - no it's not correct.  The session should not be auto-started like this, @fabpot and I recently discussed it.
    
    ---------------------------------------------------------------------------
    
    by dlsniper at 2012-06-11T07:52:55Z
    
    @Drak, ok I'll remove the patch for auto_start then but the fix for start would still stand, right?
    
    ---------------------------------------------------------------------------
    
    by drak at 2012-06-12T18:40:35Z
    
    @dlsniper - I have no objection to the rest of the PR except for the autostart stuff.  I've annotated for clarity :)
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-12T19:51:12Z
    
    This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1604158) (merged 3499980e into 37550d2).
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-12T19:52:00Z
    
    This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1604166) (merged dcc73071 into 37550d2).
    
    ---------------------------------------------------------------------------
    
    by dlsniper at 2012-06-12T19:56:51Z
    
    Seems Travis doesn't like the squashing of commits that I've did but the PR does pass the normal tests.
    @drak is this good for merging now?
    
    Thanks :)
    
    ---------------------------------------------------------------------------
    
    by dlsniper at 2012-06-13T09:05:09Z
    
    @fabpot this can be merged safely, I've just applied the patch on my production application and the patch is ok, it's just travis failing.
    
    Thanks
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-13T09:23:46Z
    
    This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1608735) (merged 1a6eabd2 into 37550d2).
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-13T09:28:26Z
    
    This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1608758) (merged 4e3a93c8 into 37550d2).
    
    ---------------------------------------------------------------------------
    
    by dlsniper at 2012-06-13T09:29:28Z
    
    I've noticed that this is failing, I'll fix it later on today.
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-13T15:14:01Z
    
    This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1611541) (merged 5504c4b7 into 37550d2).
    
    ---------------------------------------------------------------------------
    
    by drak at 2012-06-13T15:23:47Z
    
    It's possible that other tests are failing not related to this PR. Run the tests on the current master, and try rebasing your branch to the current master also.
    
    ---------------------------------------------------------------------------
    
    by dlsniper at 2012-06-13T15:44:22Z
    
    I've just reminded why this is failing on builds, I can't do them locally because of this:
    ```
    Installing dev dependencies
    Your requirements could not be solved to an installable set of packages.
    
            Problems:
                    - Problem caused by:
                            - Installation request for doctrine/orm [>= 2.2.0.0, < 2.4.0.0-dev]: Satisfiable by [doctrine/orm-2.2.2, doctrine/orm-2.2.1, doctrine/orm-2.2.0, doctrine/orm-2.2.x-dev, doctrine/orm-2.3.x-dev].
    ```
    
    I'll try and install this somehow and see what's wrong with it.
    
    ---------------------------------------------------------------------------
    
    by mvrhov at 2012-06-13T18:08:58Z
    
    @dlsniper: as @stof said to me this should be resolved in latest versions of composer, but it seems that is not. The problem is that composer cannot figure out that you are on dev-master if you try to instal dev. dependencies on feature branch. Take a look at the .travis.yml file on how to do a proper dev vendors install.
    cc @Seldaek
    
    ---------------------------------------------------------------------------
    
    by dlsniper at 2012-06-13T23:08:53Z
    
    @mvrhov Thanks for pointing this out.
    
    @drak I still got two tests not passing but I'm not sure how to fix them as adding $session->start() will either fail with the message that the session has already been started, the headers_sent() call which returns true. Any help with them will be greatly appreciated. Thanks!
    
    Here is what the HttpKernel tests are returning:
    ```
    There were 2 failures:
    
    1) Symfony\Component\HttpKernel\Tests\EventListener\LocaleListenerTest::testDefaultLocaleWithSession
    Failed asserting that two strings are equal.
    --- Expected
    +++ Actual
    @@ @@
    -'es'
    +'fr'
    
    /var/www/symfony-orig/src/Symfony/Component/HttpKernel/Tests/EventListener/LocaleListenerTest.php:51
    
    2) Symfony\Component\HttpKernel\Tests\EventListener\LocaleListenerTest::testLocaleFromRequestAttribute
    Expectation failed for method name is equal to <string:set> when invoked 1 time(s).
    Method was expected to be called 1 times, actually called 0 times.
    
    FAILURES!
    Tests: 263, Assertions: 1025, Failures: 2, Skipped: 10.
    ```
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-13T23:42:59Z
    
    This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1614883) (merged 1004b7c0 into c07e916).
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-13T23:53:06Z
    
    This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1614897) (merged f72ba0a into c07e916).
    
    ---------------------------------------------------------------------------
    
    by dlsniper at 2012-06-16T20:14:41Z
    
    @stof / @vicb Hi, do either of you think that you can either point me out to the right direction for fixing this either ping someone else for home help as @drak doesn't seem available for this and at the moment I'm pretty much clueless in what direction I should take this fix.
    
    Thanks!
    
    ---------------------------------------------------------------------------
    
    by dlsniper at 2012-06-19T14:16:29Z
    
    ping @fabpot Can you please provide some input on this one as I'm a bit stuck and seems noone else is available.
    
    ---------------------------------------------------------------------------
    
    by drak at 2012-06-20T10:24:43Z
    
    fyi - I'll be able to look again in a few days
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-07-01T07:53:28Z
    
    I'm +1 to add the `isStarted()` method, but -1 for the change of `Request::hasSession`.
    
    ---------------------------------------------------------------------------
    
    by drak at 2012-07-01T09:06:15Z
    
    @fabpot, I agree. `hasSession()` should not be changed, it's semantically incorrect to make it return effectively "hasActiveSession".
  4. @fabpot

    merged branch jalliot/load-class-cache (PR #4542)

    fabpot authored
    Commits
    -------
    
    f09789b [FrameworkBundle] Generate the class cache when warming up the cache
    
    Discussion
    ----------
    
    [FrameworkBundle] Generate the class cache when warming up the cache
    
    Bug fix: no
    Feature addition: yes
    Backwards compatibility break: no
    Symfony2 tests pass: [![Build Status](https://secure.travis-ci.org/jalliot/symfony.png?branch=load-class-cache)](http://travis-ci.org/jalliot/symfony)
    Fixes the following tickets: -
    Todo: -
    
    With this PR, the commands `cache:clear` (if `--no-warmup` hasn't been specified) and `cache:warmup` generate the class cache. Now the first page load after clearing the cache does not take over one second anymore :)
    Of course, if someone does not want to use the class cache for whatever reason, he can always remove the `$kernel->loadClassCache()` in his front controller and the cache will just be ignored...
    
    On a side note, can someone explain why [SensioDistributionBundle does not warmup the cache in the Composer post-install script](https://github.com/sensio/SensioDistributionBundle/blob/master/Composer/ScriptHandler.php#L48)?
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-10T05:18:30Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1579114) (merged baecbaee into 6266b72).
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-10T05:24:48Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1579154) (merged f09789b into 6266b72).
    
    ---------------------------------------------------------------------------
    
    by jalliot at 2012-06-28T23:18:54Z
    
    @fabpot ping
  5. @fabpot

    merged branch Tobion/requestmatcher (PR #4582)

    fabpot authored
    Commits
    -------
    
    7464dcd added phpdoc
    c413e7b [Routing] remove RequestContextAwareInterface from RequestMatcherInterface
    921be34 [Routing] fix phpdoc
    
    Discussion
    ----------
    
    [Routing] RequestMatcherInterface doesn't need context
    
    Matchers that implement RequestMatcherInterface should match a Request, thus they don't need the request context.
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-14T21:39:48Z
    
    This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1624496) (merged f5ff1fe0 into 7c91ee5).
    
    ---------------------------------------------------------------------------
    
    by schmittjoh at 2012-06-15T13:32:59Z
    
    I think it makes sense to remove the RequestContext from the RequestMatcher.
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-15T15:54:28Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1628931) (merged 7464dcd into f881d28).
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-06-26T12:32:06Z
    
    Anything missing?
  6. @fabpot
  7. @fabpot

    merged branch kriswallsmith/form/mv-humanize (PR #4645)

    fabpot authored
    Commits
    -------
    
    c1e4166 moved create of default form label to view layer
    
    Discussion
    ----------
    
    move create of default form label to view layer
    
    A small optimization if you provide custom labels in the view layer (i.e. `{{ form_label(form.name, 'Your name') }}`
    
    ```
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: yes
    Symfony2 tests pass: yes
    Fixes the following tickets: ~
    Todo: ~
    License of the code: MIT
    Documentation PR: ~
    ```
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-24T14:45:17Z
    
    This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1694310) (merged 37f0b774 into 0d4b02e).
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-24T15:03:44Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1694418) (merged c1e4166 into 0d4b02e).
  8. @fabpot

    merged branch flojon/patch-1 (PR #4638)

    fabpot authored
    Commits
    -------
    
    eb26e89 [FrameworkBundle] Fix built-in server when using query params in paths
    
    Discussion
    ----------
    
    [FrameworkBundle] Fix built-in server when using query params in paths
    
    $_SERVER['REQUEST_URI'] will contain the query params so is_file will fail.
    I propose to use $_SERVER['SCRIPT_FILENAME'] instead which contains the full path and no query params.
    
    ---------------------------------------------------------------------------
    
    by ajessu at 2012-06-23T10:17:34Z
    
    I was going to make this comment on your approach in #4484, but I'll make it here, since that issue is already closed.
    
    Your solution won't work on PHP 5.4.0, as `$_SERVER['SCRIPT_FILENAME']` will not be set [see PHP bug #60850](https://bugs.php.net/bug.php?id=60850).
    
    Also PHP 5.4.1 and up, if you don't request a file explicitely, Ex:
    
         http://localhost:8000/app_dev.php
    
    but a location, Ex:
    
        http://localhost:8000/
    
    The value of the `$_SERVER['SCRIPT_FILENAME']` will be the router file, not the script name, which makes relying on `$_SERVER['SCRIPT_FILENAME']` inconsistent. [See this comment on the php bug](https://bugs.php.net/bug.php?id=60850#1331261652)
    
    I'm not sure if (nor how?) the issue of the params should be addressed on this "default" router, to not make it overly complex.
    
    For your use case, and this is just my own early opinion without much thought, in case we can't come up with a general solution, there is always the option of defining your own router and passing it to the `server:run` command with `--router` like so:
    
        php app/console server:run --router=app/config/my_own_router.php
    
    ---------------------------------------------------------------------------
    
    by flojon at 2012-06-23T10:31:47Z
    
    So would `$_SERVER['SCRIPT_NAME']` be more reliable? Like this:
    
        if (is_file($_SERVER['DOCUMENT_ROOT'] . DIRECTORY_SEPARATOR . $_SERVER['SCRIPT_NAME'])) {
            return false;
        }
    
    I did a simple test and `$_SERVER['SCRIPT_NAME']` is set to `/` when accessing the root (using PHP 5.4.3).
    
    ---------------------------------------------------------------------------
    
    by flojon at 2012-06-23T10:51:22Z
    
    Browse around the code a bit and `$_SERVER['SCRIPT_NAME']` has been there since PHP 5.4.0:
    https://github.com/php/php-src/blob/php-5.4.0/sapi/cli/php_cli_server.c#L598
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-23T11:16:59Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1688361) (merged eb26e89 into 0d4b02e).
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-24T10:23:52Z
    
    This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1688043) (merged 71855665 into 0d4b02e).
    
    ---------------------------------------------------------------------------
    
    by CHH at 2012-06-29T07:17:32Z
    
    This works fine for me!
    
    :+1:
    
    Could someone please merge this? This issue makes the `server:run` command currently quite unusable, because it can't load CSS for example which has a `?v=` parameter.
    
    ---------------------------------------------------------------------------
    
    by ajessu at 2012-06-29T08:25:14Z
    
    :+1: from me also. Works just like `$_SERVER['REQUEST_URI']`, but doesn't include the params.
    
    Tested working on PHP 5.4.0 and 5.4.3.
  9. @fabpot
  10. @fabpot

    [Routing] fixed indentation

    fabpot authored
  11. @fabpot
Commits on Jun 30, 2012
  1. @fabpot

    [FrameworkBundle] removed the auto-starting of the session when a pre…

    fabpot authored
    …vious session exists (it is not needed anymore as the session is now always started on demand)
  2. @fabpot

    removed unneeded code

    fabpot authored
  3. @fabpot

    merged branch Partugal/patch-1 (PR #4690)

    fabpot authored
    Commits
    -------
    
    0b02e3c [FrameworkBundle] Removed unneeded parameter
    
    Discussion
    ----------
    
    Remove autortart parameter
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-30T09:25:37Z
    
    This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1742561) (merged 0b02e3c into 741927b).
  4. @linniksa
  5. @fabpot
  6. @fabpot

    merged branch drak/session_on_demand (PR #4264)

    fabpot authored
    Commits
    -------
    
    911db69 [FrameworkBundle] Typo fix
    19eeac8 [HttpFoundation] Removed erroneous reliance on session.auto_start
    dcac5d7 [HttpFoundation] Corrected docblocks and properties.
    1fd66f3 [FrameworkBundle] Remove 'auto_start' configuration parameter.
    
    Discussion
    ----------
    
    [HttpFoundation] Remove session start on demand
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
    Todo: -
    License of the code: MIT
    
    This removes false reliance on ini directive `session.auto_start` to allow a session to start when session bags are accessed before the `SessionStorageInterface` is started.
    
    Sessions must be explicitly started in all circumstances.
    
    ---------------------------------------------------------------------------
    
    by stloyd at 2012-06-13T07:22:24Z
    
    @drak Shouldn't you add note about this change in upgrade file ?
    
    ---------------------------------------------------------------------------
    
    by drak at 2012-06-13T15:13:37Z
    
    It's a development version change, so not really. But saying that, I have a bunch of documentation to amend when this gets merged and at that time I'll make sure the changelogs and upgrading are up to date as part of that.
    
    ---------------------------------------------------------------------------
    
    by dlsniper at 2012-06-13T21:57:28Z
    
    @drak If this change will kick in what does one user of Symfony 2 Standard must do in order to keep compat with this merge? I see that you said you'll update the docs but until that happens some might upgrade their app directly to master :)
    
    Thanks.
    
    ---------------------------------------------------------------------------
    
    by drak at 2012-06-14T01:36:04Z
    
    @dlsniper - nothing. This corrects a bug and inconsistency.
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-29T17:48:42Z
    
    This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1739033) (merged 19eeac8 into 62100f1).
    
    ---------------------------------------------------------------------------
    
    by drak at 2012-06-29T17:55:13Z
    
    @fabpot ping. The failing Travis is nothing to do with this PR (see the travis logs).
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-29T20:39:43Z
    
    This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1739805) (merged 911db69 into 62100f1).
Commits on Jun 29, 2012
  1. [FrameworkBundle] Typo fix

    Drak authored
  2. @fabpot

    merged 2.0

    fabpot authored
Something went wrong with that request. Please try again.